Skip to content

Conversation

Sean329
Copy link
Contributor

@Sean329 Sean329 commented Feb 19, 2025

Resolved all the auditor's findings

@Sean329 Sean329 requested a review from sentilesdal as a code owner February 20, 2025 01:59
@coveralls
Copy link
Collaborator

coveralls commented Feb 20, 2025

Pull Request Test Coverage Report for Build 13497662436

Details

  • 1 of 13 (7.69%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 86.309%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/src/matching/HyperdriveMatchingEngineV2.sol 1 13 7.69%
Files with Coverage Reduction New Missed Lines %
contracts/src/matching/HyperdriveMatchingEngineV2.sol 1 57.27%
Totals Coverage Status
Change from base Build 13323291492: -0.2%
Covered Lines: 3234
Relevant Lines: 3747

💛 - Coveralls

Copy link

github-actions bot commented Feb 20, 2025

Hyperdrive Gas Benchmark

Benchmark suite Current: 85251e2 Previous: 8d8554d Deviation Status
addLiquidity: min 33877 gas 33877 gas 0% 🟰
addLiquidity: avg 202419 gas 203679 gas -0.6186%
addLiquidity: max 187731 gas 187767 gas -0.0192%
burn: min 31471 gas 31471 gas 0% 🟰
burn: avg 136112 gas 136796 gas -0.5000%
burn: max 111163 gas 111163 gas 0% 🟰
checkpoint: min 40267 gas 40267 gas 0% 🟰
checkpoint: avg 148313 gas 148329 gas -0.0108%
checkpoint: max 149197 gas 149197 gas 0% 🟰
closeLong: min 31459 gas 31459 gas 0% 🟰
closeLong: avg 146319 gas 146517 gas -0.1351%
closeLong: max 126667 gas 126643 gas 0.0190% 🚨
closeShort: min 31425 gas 31425 gas 0% 🟰
closeShort: avg 137596 gas 137633 gas -0.0269%
closeShort: max 132669 gas 132669 gas 0% 🟰
initialize: min 31291 gas 31291 gas 0% 🟰
initialize: avg 355249 gas 355288 gas -0.0110%
initialize: max 355631 gas 355631 gas 0% 🟰
openLong: min 33440 gas 33440 gas 0% 🟰
openLong: avg 179230 gas 179303 gas -0.0407%
openLong: max 191472 gas 191472 gas 0% 🟰
openShort: min 33874 gas 33874 gas 0% 🟰
openShort: avg 180544 gas 180715 gas -0.0946%
openShort: max 170046 gas 170046 gas 0% 🟰
redeemWithdrawalShares: min 31259 gas 31259 gas 0% 🟰
redeemWithdrawalShares: avg 78336 gas 77489 gas 1.0931% 🚨
redeemWithdrawalShares: max 67470 gas 67460 gas 0.0148% 🚨
removeLiquidity: min 31243 gas 31243 gas 0% 🟰
removeLiquidity: avg 213276 gas 213479 gas -0.0951%
removeLiquidity: max 218315 gas 220553 gas -1.0147%

This comment was automatically generated by workflow using github-action-benchmark.

@Sean329 Sean329 changed the title WIP PR -- To resolve the auditor's comments on Matching Engine V2 To resolve the auditor's comments on Matching Engine V2 Feb 24, 2025
Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sean329 Sean329 added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit 452e252 Feb 25, 2025
35 checks passed
@Sean329 Sean329 deleted the sean/feature/match-engine-post-audit-fix branch February 25, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants