Skip to content

Conversation

jalextowle
Copy link
Contributor

@jalextowle jalextowle commented Mar 10, 2025

Resolved Issues

Description

Addresses the issues mentioned in Kurt Barry's review of the mint and burn functions

@jalextowle jalextowle changed the title Added the supportsInterface function Fixed Kurt Barry's audit feedback Mar 10, 2025
Copy link

github-actions bot commented Mar 10, 2025

Hyperdrive Gas Benchmark

Benchmark suite Current: 74b7c39 Previous: 56ec8cb Deviation Status
addLiquidity: min 33877 gas 33877 gas 0% 🟰
addLiquidity: avg 202075 gas 203470 gas -0.6856%
addLiquidity: max 187767 gas 189527 gas -0.9286%
burn: min 31471 gas 31471 gas 0% 🟰
burn: avg 136419 gas 136585 gas -0.1215%
burn: max 111163 gas 111163 gas 0% 🟰
checkpoint: min 40267 gas 40267 gas 0% 🟰
checkpoint: avg 148325 gas 148322 gas 0.0020% 🚨
checkpoint: max 149197 gas 149197 gas 0% 🟰
closeLong: min 31459 gas 31459 gas 0% 🟰
closeLong: avg 146460 gas 146436 gas 0.0164% 🚨
closeLong: max 126643 gas 126631 gas 0.0095% 🚨
closeShort: min 31425 gas 31425 gas 0% 🟰
closeShort: avg 137937 gas 137684 gas 0.1838% 🚨
closeShort: max 133396 gas 132669 gas 0.5480% 🚨
initialize: min 31291 gas 31291 gas 0% 🟰
initialize: avg 355230 gas 355230 gas 0% 🟰
initialize: max 355631 gas 355631 gas 0% 🟰
openLong: min 33440 gas 33440 gas 0% 🟰
openLong: avg 179161 gas 178995 gas 0.0927% 🚨
openLong: max 191472 gas 191472 gas 0% 🟰
openShort: min 33874 gas 33874 gas 0% 🟰
openShort: avg 180771 gas 180932 gas -0.0890%
openShort: max 170046 gas 170046 gas 0% 🟰
redeemWithdrawalShares: min 31259 gas 31259 gas 0% 🟰
redeemWithdrawalShares: avg 78475 gas 77654 gas 1.0573% 🚨
redeemWithdrawalShares: max 67470 gas 67460 gas 0.0148% 🚨
removeLiquidity: min 31243 gas 31243 gas 0% 🟰
removeLiquidity: avg 212812 gas 213340 gas -0.2475%
removeLiquidity: max 210777 gas 220553 gas -4.4325%

This comment was automatically generated by workflow using github-action-benchmark.

@coveralls
Copy link
Collaborator

coveralls commented Mar 10, 2025

Pull Request Test Coverage Report for Build 13824512289

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 86.624%

Totals Coverage Status
Change from base Build 13757743675: 0.06%
Covered Lines: 3251
Relevant Lines: 3753

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants