feat(tiptap): reject mentions of tags unavailable for the template state

Legacy text validation implicitly rejected a tag not available for the
template's DOSSIER_STATE (its libelle simply didn't resolve), but a
tiptap mention carries its tag id verbatim and slipped through. Check
non-champ mention ids against the state-filtered catalog, for mail
templates and attestations v2 alike.

The attestation v2 factory carried individual mentions on a
non-individual procedure — content the UI cannot produce and that this
validation now rejects; it uses an identity-agnostic tag instead.

Author: colinux

app/models/concerns/tags_substitution_concern.rb

@@ -287,11 +287,19 @@ def used_type_de_champ_tags(text_or_tiptap)
         used_tags_and_libelle_for(text_or_tiptap.to_s)
       end
 
+    available_ids = nil
+
     used_tags.filter_map do |(tag, libelle)|
       if tag.nil?
         [libelle]
       elsif !tag.in?(SHARED_TAG_IDS) && tag.start_with?('tdc')
         [libelle, tag.gsub(/^tdc/, '').to_i]
+      else
+        # A tiptap mention carries its tag id verbatim, so ids of tags unknown or
+        # not available for this template's DOSSIER_STATE must be rejected here —
+        # the legacy text parsing did it implicitly (the libelle didn't resolve).
+        available_ids ||= procedure_types_de_champ_tags.map { _1[:id] }
+        [libelle] unless tag.in?(available_ids)
       end
     end
   end

spec/factories/attestation_template.rb

@@ -40,8 +40,7 @@
           {
             "type" => "paragraph",
             "content" => [
-              { "text" => "Nom: ", "type" => "text" }, { "type" => "mention", "attrs" => { "id" => "individual_last_name", "label" => "prénom" } }, { "text" => " ", "type" => "text" },
-              { "type" => "mention", "attrs" => { "id" => "individual_first_name", "label" => "nom" } }, { "text" => " ", "type" => "text" },
+              { "text" => "Déposé le : ", "type" => "text" }, { "type" => "mention", "attrs" => { "id" => "dossier_depose_at", "label" => "date de dépôt" } }, { "text" => " ", "type" => "text" },
             ],
           },
         ],

spec/models/attestation_template_spec.rb

@@ -227,8 +227,25 @@
     end
 
     context 'body v2' do
-      let(:attestation) { create(:attestation_template, :v2) }
-      let(:dossier) { create(:dossier, procedure: attestation.procedure, individual: build(:individual, nom: 'Doe', prenom: 'John')) }
+      let(:procedure) { create(:procedure, :for_individual) }
+      let(:attestation) do
+        create(:attestation_template, :v2, procedure:, json_body: {
+          "type" => "doc",
+          "content" => [
+            { "type" => "title", "attrs" => { "textAlign" => "center" }, "content" => [{ "text" => "Mon titre pour ", "type" => "text" }, { "type" => "mention", "attrs" => { "id" => "dossier_procedure_libelle", "label" => "libellé démarche" } }] },
+            {
+              "type" => "paragraph",
+              "content" => [
+                { "text" => "Nom: ", "type" => "text" },
+                { "type" => "mention", "attrs" => { "id" => "individual_last_name", "label" => "nom" } },
+                { "text" => " ", "type" => "text" },
+                { "type" => "mention", "attrs" => { "id" => "individual_first_name", "label" => "prénom" } },
+              ],
+            },
+          ],
+        })
+      end
+      let(:dossier) { create(:dossier, procedure:, individual: build(:individual, nom: 'Doe', prenom: 'John')) }
 
       it do
         body = attestation.render_attributes_for(dossier: dossier)[:body]

spec/models/concerns/mail_template_concern_spec.rb

@@ -326,5 +326,26 @@
       expect(mail).not_to be_valid
       expect(mail.errors[:body]).to be_present
     end
+
+    it 'invalide une mention d’une balise indisponible pour l’état du template (parité legacy)' do
+      decision_mention = {
+        "type" => "doc",
+        "content" => [
+          {
+            "type" => "paragraph", "content" => [
+              { "type" => "mention", "attrs" => { "id" => "dossier_processed_at", "label" => "date de décision" } },
+            ],
+          },
+        ],
+      }
+
+      mail.json_body = decision_mention
+      expect(mail).not_to be_valid
+      expect(mail.errors[:json_body]).to be_present
+
+      closed_mail = Mails::ClosedMail.default_for_procedure(procedure)
+      closed_mail.json_body = decision_mention
+      expect(closed_mail).to be_valid
+    end
   end
 end