Skip to content

ETQ Tech je veux que la date d'expiration d'un dossier soit persistée en base#11752

Merged
E-L-T merged 5 commits into
mainfrom
add-expired-at-to-dossiers
Jun 23, 2025
Merged

ETQ Tech je veux que la date d'expiration d'un dossier soit persistée en base#11752
E-L-T merged 5 commits into
mainfrom
add-expired-at-to-dossiers

Conversation

@E-L-T

@E-L-T E-L-T commented Jun 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Voir #11741

Dans cette PR :

  • on ajoute l'attribut expired_at à la table dossiers
  • on met à jour ce champ lors de l'update en brouillon, et ensuite lors des changements d'état. Sa valeur est nulle quand le dossier est en instruction
  • un maintenance task pour mettre à jour les dossiers

Dans une PR à suivre, une fois les données rattrapées, on pourra se baser sur la valeur de expired_at plutôt que sur celle d'expiration_date pour afficher la valeur dans l'interface usager/instructeur.

@E-L-T
E-L-T force-pushed the add-expired-at-to-dossiers branch from 345ce10 to 9190c11 Compare June 11, 2025 08:25
@codecov

codecov Bot commented Jun 11, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.90%. Comparing base (34415f4) to head (c380fec).

Files with missing lines Patch % Lines
...ance/t20250611backfill_dossiers_expired_at_task.rb 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11752      +/-   ##
==========================================
+ Coverage   89.88%   89.90%   +0.01%     
==========================================
  Files        1275     1276       +1     
  Lines       28131    28153      +22     
  Branches     5808     5808              
==========================================
+ Hits        25286    25310      +24     
+ Misses       2845     2843       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@E-L-T
E-L-T force-pushed the add-expired-at-to-dossiers branch 5 times, most recently from 027e501 to 9c3b504 Compare June 11, 2025 10:01
@E-L-T
E-L-T marked this pull request as ready for review June 11, 2025 10:01
@E-L-T
E-L-T requested a review from Benoit-MINT June 11, 2025 10:01
Benoit-MINT
Benoit-MINT reviewed Jun 17, 2025
View reviewed changes

@Benoit-MINT Benoit-MINT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci Eric d'avoir pris ce sujet!
Si on regarde toutes les variables de Dossier#expiration_date, on voit qu'on a aussi le facteur de l'extension de conservation : celui propre à la procédure que peut ajuster l'admin (ou DS), celui propre au dossier que peut effectuer l'instructeur. En l'état je n'ai pas l'impression que le cas échant, cela update l'attribut expired_at

@E-L-T
E-L-T force-pushed the add-expired-at-to-dossiers branch from 8ca44ec to 47e40b0 Compare June 20, 2025 07:54
@E-L-T
E-L-T force-pushed the add-expired-at-to-dossiers branch 4 times, most recently from 68c31b8 to 5291915 Compare June 20, 2025 16:12
@E-L-T
E-L-T force-pushed the add-expired-at-to-dossiers branch from 5291915 to d4b4cd5 Compare June 20, 2025 16:18
@E-L-T
E-L-T force-pushed the add-expired-at-to-dossiers branch from d4b4cd5 to c380fec Compare June 20, 2025 16:23
@E-L-T

E-L-T commented Jun 23, 2025

Copy link
Copy Markdown
Contributor Author

Merci pour le retour @Benoit-MINT j'ai ajouté ça dans ceux commits

@Benoit-MINT

Benoit-MINT commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

Merci pour le retour @Benoit-MINT j'ai ajouté ça dans ceux commits

top!

@E-L-T
E-L-T added this pull request to the merge queue Jun 23, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 23, 2025
@E-L-T
E-L-T added this pull request to the merge queue Jun 23, 2025
Merged via the queue into main with commit 99e1a54 Jun 23, 2025
19 checks passed
@E-L-T
E-L-T deleted the add-expired-at-to-dossiers branch June 23, 2025 13:06
@E-L-T E-L-T mentioned this pull request Oct 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchak tchak tchak approved these changes
@Benoit-MINT Benoit-MINT Benoit-MINT approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@E-L-T @Benoit-MINT @tchak