Skip to content

ETQ Administrateur, je souhaite que les instructeurs ne puissent se connecter à certaines démarches qu'avec PROCONNECT#11799

Merged
mmagn merged 9 commits into
mainfrom
fix-11159
Jul 8, 2025
Merged

ETQ Administrateur, je souhaite que les instructeurs ne puissent se connecter à certaines démarches qu'avec PROCONNECT#11799
mmagn merged 9 commits into
mainfrom
fix-11159

Conversation

@mmagn

@mmagn mmagn commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

Fixes #11159
Fonctionnalité feature flipée pour l'instant
On ajoute une tuile de configuration coté Admin
Capture d’écran 2025-07-03 à 15 06 17
Un écran de configuration, qui necessite pour l'activation que l'admin soit Pro connecté
Capture d’écran 2025-07-03 à 15 06 21
Capture d’écran 2025-07-03 à 15 06 48
Capture d’écran 2025-07-03 à 15 07 37

Une fois la fonctionnalité activée, les admins et instructeurs sont redirigés vers la page pro connect s'ils souhaitent acceder à une démarche protégé sans pro connexion.
Capture d’écran 2025-07-03 à 15 08 02

@mmagn
mmagn force-pushed the fix-11159 branch 2 times, most recently from 3b8ff9b to dce0f43 Compare June 24, 2025 15:53
@codecov

codecov Bot commented Jun 24, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.54%. Comparing base (28d3395) to head (79ca832).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
...ntrollers/administrateurs/procedures_controller.rb 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11799      +/-   ##
==========================================
- Coverage   89.91%   86.54%   -3.38%     
==========================================
  Files        1291     1293       +2     
  Lines       28372    28419      +47     
  Branches     5873     5880       +7     
==========================================
- Hits        25512    24594     -918     
- Misses       2860     3825     +965     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mmagn
mmagn force-pushed the fix-11159 branch 5 times, most recently from 6777b92 to 4f72b1b Compare July 2, 2025 13:16
@mmagn
mmagn marked this pull request as ready for review July 3, 2025 08:33
@mmagn
mmagn requested a review from LeSim July 3, 2025 08:34
@mmagn
mmagn marked this pull request as draft July 3, 2025 10:53
@mmagn
mmagn requested review from LeSim and removed request for LeSim July 3, 2025 10:53
@mmagn
mmagn marked this pull request as ready for review July 3, 2025 13:11

@LeSim LeSim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magnifico

Comment thread app/controllers/concerns/pro_connect_session_concern.rb
Comment thread app/controllers/instructeurs/procedures_controller.rb
@mmagn
mmagn added this pull request to the merge queue Jul 8, 2025
Merged via the queue into main with commit 27ed229 Jul 8, 2025
23 of 28 checks passed
@mmagn
mmagn deleted the fix-11159 branch July 8, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ETQ Administrateur, je souhaite que les instructeurs ne puissent se connecter des certaines démarches qu'avec PROCONNECT, Carte pour le MI)

2 participants