feat: expose the champs changed in a correction via a traitement checkpoint by tchak · Pull Request #13235 · demarche-numerique/demarche.numerique.gouv.fr

tchak · 2026-06-03T08:50:59Z

When a dossier is corrected (by the usager or an instructeur), the champs moved out of the buffer stream are now tagged with the history stream id as a "checkpoint", and that same id is stored on the resulting traitement. This links each correction traitement to the exact set of champs it changed.

Add a checkpoint column to champs and traitements.
merge_user/instructeur_buffer_stream! returns the history stream id and stamps the moved champs with it; submit helpers thread it onto the traitement.
Introduce ChangedColumn, which diffs the checkpointed champs against their reference values and yields displayable columns with their new values (handling repetitions).
Traitement#changed_columns / #has_changes? surface a correction's changes, and Dossier#user_changed_columns / #instructeur_changed_columns expose pending buffer changes.
Expose changedColumns on the GraphQL Traitement type.

mfo

pas de bug, mais des proposition de refactoring. a prendre ou a laisser

mfo · 2026-06-16T13:03:49Z

+    lines << diff_line(t('.removed_values'), removed) if removed.present?
+    return tag.em(t('.changed')) if lines.empty?
+
+    safe_join(lines, tag.br)


arrggsshhhhh le br

oui, mais je ne sais pas trop comment s'en sortir ici. Nous sommes déjà à l'intérieur d'un dd

…kpoint When a dossier is corrected (by the usager or an instructeur), the champs moved out of the buffer stream are now tagged with the history stream id as a "checkpoint", and that same id is stored on the resulting traitement. This links each correction traitement to the exact set of champs it changed. - Add a `checkpoint` column to `champs` and `traitements`. - `merge_user/instructeur_buffer_stream!` returns the history stream id and stamps the moved champs with it; submit helpers thread it onto the traitement. - Introduce `ChangedColumn`, which diffs the checkpointed champs against their reference values and yields displayable columns with their new values (handling repetitions). - `Traitement#changed_columns` / `#has_changes?` surface a correction's changes, and `Dossier#user_changed_columns` / `#instructeur_changed_columns` expose pending buffer changes. - Expose `changedColumns` on the GraphQL `Traitement` type.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

tchak force-pushed the push-nxrnqluquupo branch 2 times, most recently from 4614f85 to 2606662 Compare June 3, 2026 12:45

mfo approved these changes Jun 10, 2026

View reviewed changes

tchak force-pushed the push-nxrnqluquupo branch 11 times, most recently from a57a78f to 0149996 Compare June 16, 2026 11:30