ETQ instructeur utilisant un terminal mobile, je veux que le détail des notifications soit lisible#13294
Open
inseo wants to merge 2 commits into
Open
ETQ instructeur utilisant un terminal mobile, je veux que le détail des notifications soit lisible#13294inseo wants to merge 2 commits into
inseo wants to merge 2 commits into
Conversation
inseo
force-pushed
the
a11y-notif-details
branch
3 times, most recently
from
June 16, 2026 10:51
5ba91f4 to
cd24815
Compare
mmagn
approved these changes
Jun 16, 2026
Member
|
En regardant ce code, je ne peux pas m'empêcher de penser que ce serait mieux sans JS, avec du CSS branché sur plusieurs breakpoints de largeur d'écran. Vous en pensez quoi ? |
Contributor
Author
|
@tchak Justement, le faire en full CSS n'est pas possible car ça signifierait que la quantité d'informations visibles diffère suivant le terminal utilisé. Et c'est justement ce que je cherche à éviter. :) Mais en relisant le code JS, je me rends compte que ça n'est pas le cas et que ça fonctionne bien au redimensionnement de la page, mais pas au chargement initial sur des fenêtres de différentes largeurs. :s Je vais donc modifier le code JS pour que la valeur à partir de laquelle les éléments sont tronquées soit immuable, indépendamment du terminal utilisé. :) |
inseo
marked this pull request as draft
June 18, 2026 13:20
inseo
force-pushed
the
a11y-notif-details
branch
from
June 18, 2026 14:34
cd24815 to
e316c73
Compare
inseo
marked this pull request as ready for review
June 18, 2026 14:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problèmes
Après
notif-OK.mp4
Avant
notif-KO.mp4