Tech: renomme les accesseurs de champs et de types de champ#13487
Merged
Conversation
Rename projection accessors to describe what they return: - ProcedureRevision#types_de_champ_public -> root_types_de_champ_public - ProcedureRevision#types_de_champ_private -> root_types_de_champ_private - Dossier#project_champs -> champs - Dossier#project_champs_public -> root_champs_public - Dossier#project_champs_private -> root_champs_private - Dossier#project_champs_public_all -> flat_champs_public - Dossier#project_champs_private_all -> flat_champs_private The Dossier delegate to revision follows the ProcedureRevision rename. Names that only share the spelling are left untouched: the procedure factory transients, ProcedureSerializer JSON keys, validation scope symbols and i18n keys. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
colinux
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renommage mécanique, sans changement de comportement.
ProcedureRevision#types_de_champ_publicroot_types_de_champ_publicProcedureRevision#types_de_champ_privateroot_types_de_champ_privateDossier#project_champschampsDossier#project_champs_publicroot_champs_publicDossier#project_champs_privateroot_champs_privateDossier#project_champs_public_allflat_champs_publicDossier#project_champs_private_allflat_champs_privatePoints d'attention pour la revue
Dossierdéléguaittypes_de_champ_public/types_de_champ_privateà sarevision: la délégation suit le renommage deProcedureRevision. C'est le seul endroit qui va un peu au-delà du renommage demandé.Dossier#champsétait libre : aucune méthode ni association de ce nom (l'association estchamp_data; lewhere(champs: {...})est un nom de table).procedure, les clés JSON deProcedureSerializer(has_many :types_de_champ_private), les symboles de scope de validation et les clés i18n.Tests
rubocopethaml-lintOK. Suites models / services / graphql / components / views / validators / controllers / jobs / lib / policies / helpers / tasks / perf passantes.Les échecs restants en local sont préexistants et sans lien avec ce renommage (vérifié en rejouant les mêmes specs sur
maindans un workspace propre) : ils viennent tous d'un souci d'environnement sur la création des zip (ArchiveUploader/File.size) et d'appels sortants vers l'API Adresse. On s'appuie sur la CI pour confirmer.🤖 Generated with Claude Code