Skip to content

Conversation

@inbalapt1
Copy link
Contributor

@inbalapt1 inbalapt1 commented Oct 15, 2025

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CRTX-189927

Description

Validation for types of args and outputs of actions.

@inbalapt1 inbalapt1 self-assigned this Oct 15, 2025
@github-actions
Copy link

Changelog(s) in markdown:

  • Added AG105 validation. #5095

@inbalapt1 inbalapt1 requested review from jbabazadeh and removed request for jbabazadeh October 15, 2025 14:13
@github-actions
Copy link

Changelog(s) in markdown:

  • Added AG105 to validate that the types of arguments and outputs are valid. #5095

@inbalapt1 inbalapt1 requested a review from dantavori October 16, 2025 13:28
Copy link
Contributor

@yedidyacohenpalo yedidyacohenpalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, see the comments.
Additionally, I’d suggest splitting args and outputs into two separate validations.

and list the valid type options.
"""
# Valid content item
valid_action = AgentixAction(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
valid_action = AgentixAction(
valid_action = create_agentix_action_object(
....

Please try to use create_agentix_action_object() insted.

)

# Invalid types for both args and outputs
invalid_action = AgentixAction(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
invalid_action = AgentixAction(
invalid_action = create_agentix_action_object(

Same in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants