-
Notifications
You must be signed in to change notification settings - Fork 87
is_valid_types validation #5095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Changelog(s) in markdown:
|
|
Changelog(s) in markdown:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, see the comments.
Additionally, I’d suggest splitting args and outputs into two separate validations.
| and list the valid type options. | ||
| """ | ||
| # Valid content item | ||
| valid_action = AgentixAction( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| valid_action = AgentixAction( | |
| valid_action = create_agentix_action_object( | |
| .... |
Please try to use create_agentix_action_object() insted.
| ) | ||
|
|
||
| # Invalid types for both args and outputs | ||
| invalid_action = AgentixAction( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| invalid_action = AgentixAction( | |
| invalid_action = create_agentix_action_object( |
Same in here.
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CRTX-189927
Description
Validation for types of args and outputs of actions.