AG105 Validate display in agentix action

.changelog/5096.yml

@@ -0,0 +1,4 @@
+changes:
+- description: Added a new AG105 validation.
+  type: internal
+pr_number: 5096

demisto_sdk/commands/validate/sdk_validation_config.toml

@@ -162,6 +162,7 @@ select = [
   "AG101",
   "AG102",
   "AG103",
+  "AG105",
   "DS100",
   "DS101",
   "DS105",
@@ -323,6 +324,7 @@ select = [
   "AG101",
   "AG102",
   "AG103",
+  "AG105",
   "PA100",
   "PA101",
   "PA102",

demisto_sdk/commands/validate/tests/AG_validators_test.py

@@ -1,14 +1,20 @@
 from pathlib import Path
 
+import pytest
+
 from demisto_sdk.commands.content_graph.objects.agentix_action import AgentixAction
 from demisto_sdk.commands.content_graph.objects.agentix_agent import AgentixAgent
 from demisto_sdk.commands.content_graph.objects.script import Script
+from demisto_sdk.commands.validate.tests.test_tools import create_agentix_action_object
 from demisto_sdk.commands.validate.validators.AG_validators.AG100_is_forbidden_content_item import (
     IsForbiddenContentItemValidator,
 )
 from demisto_sdk.commands.validate.validators.AG_validators.AG101_is_correct_mp import (
     IsCorrectMPValidator,
 )
+from demisto_sdk.commands.validate.validators.AG_validators.AG105_is_display_name_valid import (
+    IsDisplayNameValidValidator,
+)
 
 
 def test_is_forbidden_content_item():
@@ -215,3 +221,54 @@ def test_is_correct_marketplace():
     assert results[0].message == (
         "The following Agentix related content item 'test' should have only marketplace 'platform'."
     )
+
+
+@pytest.mark.parametrize(
+    "content_items, expected_number_of_failures",
+    [
+        # Case 1: All valid AgentixAction displays
+        (
+            [
+                create_agentix_action_object(paths=["display"], values=["ValidName"]),
+                create_agentix_action_object(paths=["display"], values=["Valid_Name"]),
+                create_agentix_action_object(paths=["display"], values=["Valid-Name"]),
+                create_agentix_action_object(paths=["display"], values=["Valid Name"]),
+                create_agentix_action_object(paths=["display"], values=["A123"]),
+                create_agentix_action_object(paths=["display"], values=["A_1-2 3"]),
+            ],
+            0,
+        ),
+        # Case 2: One invalid (starts with digit), one valid
+        (
+            [
+                create_agentix_action_object(paths=["display"], values=["1Invalid"]),
+                create_agentix_action_object(paths=["display"], values=["ValidName"]),
+            ],
+            1,
+        ),
+        # Case 3: Invalid (contains forbidden character)
+        ([create_agentix_action_object(paths=["display"], values=["Invalid!"])], 1),
+        # Case 4: Multiple invalid
+        (
+            [
+                create_agentix_action_object(paths=["display"], values=["1Invalid"]),
+                create_agentix_action_object(paths=["display"], values=["Invalid!"]),
+                create_agentix_action_object(paths=["display"], values=["ValidName"]),
+            ],
+            2,
+        ),
+    ],
+)
+def test_IsDisplayNameValid_obtain_invalid_content_items(
+    content_items, expected_number_of_failures
+):
+    """
+    Given
+    - AgentixAction content_items with various display values.
+    When
+    - Calling the IsDisplayNameValid.obtain_invalid_content_items function.
+    Then
+    - Make sure the right amount of failure return.
+    """
+    results = IsDisplayNameValidValidator().obtain_invalid_content_items(content_items)
+    assert len(results) == expected_number_of_failures

demisto_sdk/commands/validate/validators/AG_validators/AG105_is_display_name_valid.py

@@ -0,0 +1,44 @@
+from __future__ import annotations
+
+import re
+from typing import Iterable, List
+
+from demisto_sdk.commands.content_graph.objects.agentix_action import AgentixAction
+from demisto_sdk.commands.validate.validators.base_validator import (
+    BaseValidator,
+    ValidationResult,
+)
+
+ContentTypes = AgentixAction
+
+
+class IsDisplayNameValidValidator(BaseValidator[ContentTypes]):
+    error_code = "AG105"
+    description = "AgentixAction display value must start with a letter (either lower or upper case) and contain only the following characters: lowercase letters, uppercase letters, digits, underscores, hyphens, spaces."
+    rationale = "Display names must be user-friendly and conform to standards."
+    error_message = "The following Agentix action display value is invalid: {0}. \n AgentixAction display value must start with a letter (either lower or upper case) and contain only the following characters: lowercase letters, uppercase letters, digits, underscores, hyphens, spaces."
+
+    related_field = "display"
+    is_auto_fixable = False
+
+    AGENTIX_ACTION_DISPLAY_NAME_PATTERN = re.compile(r"^[A-Za-z][A-Za-z0-9_\- ]*$")
+
+    def obtain_invalid_content_items(
+        self, content_items: Iterable[ContentTypes]
+    ) -> List[ValidationResult]:
+        validation_results = []
+        for content_item in content_items:
+            display_name = getattr(content_item, "display_name", None)
+            if not display_name or not self.AGENTIX_ACTION_DISPLAY_NAME_PATTERN.match(
+                display_name
+            ):
+                validation_results.append(
+                    ValidationResult(
+                        validator=self,
+                        message=self.error_message.format(
+                            display_name,
+                        ),
+                        content_object=content_item,
+                    )
+                )
+        return validation_results