argoCD managed version #32
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManAnRuck
force-pushed
the
feature/argocd
branch
from
b7f09e9 to
6b8f442
Compare
ManAnRuck
force-pushed
the
feature/argocd
branch
from
6b8f442 to
45eb732
Compare
ManAnRuck
force-pushed
the
feature/argocd
branch
from
45eb732 to
f561e43
Compare
There was a problem hiding this comment.
PR Overview
This PR updates the deployment configurations for various services to include explicit container port definitions, ensuring that ArgoCD has the correct networking configuration when managing these resources.
- Added explicit "ports" sections for democracy-app, qr-code-handler, democracy-api, bundestagio-admin, bundestagio, bundestagio-dip, and democracy-mongo containers.
- Adjusted the kustomization.yaml resources list formatting.
Reviewed Changes
| File | Description |
|---|---|
| kustomize/base/main/democracy-app-depl.yaml | Added container port 3000/TCP entry. |
| kustomize/base/main/qr-code-handler-depl.yaml | Added container port 3000/TCP entry. |
| kustomize/base/main/democracy-api-depl.yaml | Added container port 3000/TCP entry. |
| kustomize/base/local/democracy-mongo-depl.yaml | Added container port 27017 entry. |
| kustomize/base/main/bundestagio-depl.yaml | Added container port 3100/TCP entry. |
| kustomize/base/main/bundestagio-dip-depl.yaml | Added container port 3101/TCP entry. |
| kustomize/base/main/bundestagio-admin-depl.yaml | Added container port 3000/TCP entry. |
| kustomize/base/main/kustomization.yaml | Adjusted resources list formatting, note potential nested list issue. |
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
kustomize/base/main/kustomization.yaml:4
- The extra dash before '../gorush' creates a nested list which may break the resource referencing in kustomization. Please adjust the indenting so that the list remains flat.
- - ../gorush
added 5 commits
March 22, 2025 16:57
Signed-off-by: Manuel Ruck <[email protected]>
Signed-off-by: Manuel Ruck <[email protected]>
Signed-off-by: Manuel Ruck <[email protected]>
Signed-off-by: Manuel Ruck <[email protected]>
Signed-off-by: Manuel Ruck <[email protected]>
ManAnRuck
force-pushed
the
feature/argocd
branch
from
fe41590 to
9f10bea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.