-
Notifications
You must be signed in to change notification settings - Fork 533
Update the Continuous Deployment pipeline with a minimal amount of dependencies #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Continuous Deployment pipeline with a minimal amount of dependencies #971
Conversation
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
… into merge-dotfiles-script
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but you dropped the call to upx. Could you please include it? (except for Windows: it causes some antivirus warnings, for some reason)
|
Currently, the CI fails for aarch64_linux_android but it is a known issue from cross-rs/cross with rust versions greater than 1.68. (See cross-rs/cross#1217) |
Ok, since the size of the binaries weren't really big I didn't think of putting it back in the CI script but alright. |
For this to work, you need to use cross-rs's with a specific SHA. Here's what I did in another project of mine: cargo install -f cross --git https://github.com/cross-rs/cross --rev ac4c11ce |
IIRC, for some builds it was able to shrink ~9MB down to ~4MB, which I think is pretty reasonable. |
It could be a solution but I don't think it's a healthy practice to have to unpin from a given tag and pin the project to a git ref. If we're near the release date and cross-rs hasn't moved forward its 0.3 release we will temporarily pin our CI to a specifc git ref for the release but I would like this to be a one-time workaround. |
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
|
@denisidoro I'm going to add back UPX but until I've found how you installed it and used it I'm merging this PR in order to close the related issues since they are not dependent of the use of UPX. |
This PR tries to make the current pipeline of navi with the least amount of dependencies, which also include the
dotfilesrepository.This PR is at a WIP state and is opened to receive feedback and required changes, although it will only be opened until 14/04/2025, after that it will be merged into master.
All platforms should be able to build without an issue now.
@denisidoro, if you feel like anything should be modified, let me know.
Fixes: #969
Closes: #957
Fixes: #869
EDIT: This PR also closes #957 and its related issue #869