Skip to content

Conversation

@alexis-opolka
Copy link
Collaborator

@alexis-opolka alexis-opolka commented Apr 7, 2025

This PR tries to make the current pipeline of navi with the least amount of dependencies, which also include the dotfiles repository.

This PR is at a WIP state and is opened to receive feedback and required changes, although it will only be opened until 14/04/2025, after that it will be merged into master.
All platforms should be able to build without an issue now.

@denisidoro, if you feel like anything should be modified, let me know.

Fixes: #969
Closes: #957
Fixes: #869

EDIT: This PR also closes #957 and its related issue #869

Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
Signed-off-by: alexis-opolka <[email protected]>
@alexis-opolka alexis-opolka added the dependencies Pull requests that update a dependency file label Apr 7, 2025
@alexis-opolka alexis-opolka self-assigned this Apr 7, 2025
Copy link
Owner

@denisidoro denisidoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you dropped the call to upx. Could you please include it? (except for Windows: it causes some antivirus warnings, for some reason)

@alexis-opolka
Copy link
Collaborator Author

Currently, the CI fails for aarch64_linux_android but it is a known issue from cross-rs/cross with rust versions greater than 1.68. (See cross-rs/cross#1217)

@alexis-opolka
Copy link
Collaborator Author

LGTM, but you dropped the call to upx. Could you please include it? (except for Windows: it causes some antivirus warnings, for some reason)

Ok, since the size of the binaries weren't really big I didn't think of putting it back in the CI script but alright.

@denisidoro
Copy link
Owner

Currently, the CI fails for aarch64_linux_android but it is a known issue from cross-rs/cross with rust versions greater than 1.68. (See cross-rs/cross#1217)

For this to work, you need to use cross-rs's with a specific SHA. Here's what I did in another project of mine:

cargo install -f cross --git https://github.com/cross-rs/cross --rev ac4c11ce

@denisidoro
Copy link
Owner

denisidoro commented Apr 8, 2025

Ok, since the size of the binaries weren't really big I didn't think of putting it back in the CI script but alright.

IIRC, for some builds it was able to shrink ~9MB down to ~4MB, which I think is pretty reasonable.

@alexis-opolka
Copy link
Collaborator Author

Currently, the CI fails for aarch64_linux_android but it is a known issue from cross-rs/cross with rust versions greater than 1.68. (See cross-rs/cross#1217)

For this to work, you need to use cross-rs's with a specific SHA. Here's what I did in another project of mine:

cargo install -f cross --git https://github.com/cross-rs/cross --rev ac4c11ce

It could be a solution but I don't think it's a healthy practice to have to unpin from a given tag and pin the project to a git ref.
It's better to wait a reasonable time for cross-rs/cross to achieve its 0.3 release and upgrade our CI then.
I already proposed my help to move forward with the 0.3 release we'll see how it goes.

If we're near the release date and cross-rs hasn't moved forward its 0.3 release we will temporarily pin our CI to a specifc git ref for the release but I would like this to be a one-time workaround.

@alexis-opolka
Copy link
Collaborator Author

@denisidoro I'm going to add back UPX but until I've found how you installed it and used it I'm merging this PR in order to close the related issues since they are not dependent of the use of UPX.

@alexis-opolka alexis-opolka merged commit 138b7e0 into denisidoro:master Apr 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move required denisidoro/dotfiles scripts into navi Security concern about Windows binary (v2.23.0)

2 participants