fix: prevent prompt corruption in fish v4 #982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fish v4 introduced new multiline prompt rendering behavior that breaks when interactive commands like `navi` are injected via keybindings. this resulted in partial prefix symbols (e.g. from a prompt's newline component) being left on screen and improperly rendering the expanded command (e.g. `gzgzip` instead of `gzip`). this forces a full redraw so it's cosmetically identical to running `navi` (as a command without insertion)
|
Thanks for opening this pull request! |
alexis-opolka
requested review from
alexis-opolka
and removed request for
denisidoro
|
Hi @lamchau , Thank you for your PR. If you can, it would be better to enclose the redraw inside a condition since it doesn't apply on every version of fish. |
|
@alexis-opolka - added a check in 0076018! |
|
It looks good to me! Could you just add some comments in the code on why we redraw if the version is greater than 4? After that I'll merge this PR, thanks a lot. ^^ |
|
Thanks a lot @lamchau ! |
|
Congrats on merging your first pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fish v4 introduced new multiline prompt rendering behavior that breaks when interactive commands like
naviare injected via keybindings. this resulted in partial prefix symbols (e.g. from a prompt's newline component) being left on screen and improperly rendering the expanded command (e.g.gzgzipinstead ofgzip).this forces a full redraw so it's cosmetically identical to running
navi(as a command without insertion)Steps to repro
Prerequisites
gzip.cheat\cgkeybind (vianavi widget fish | source)gzipcheat (e.g.gzip foo)Expected:
gzip --keep --best fooActual:
gzgzip --keep --best foo(command is correct, painting is not)