Skip to content

App 1535 optimize lazyload #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

App 1535 optimize lazyload #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1ea2edb
Merge branch 'master' of github.com:dennisinteractive/react-gpt
willhowlett Nov 4, 2020
6ce5336
APP-1535 add viewableTriggerTop functionality
willhowlett Nov 5, 2020
719f52a
APP-1535 use percentage for value of viewableTriggerTop
willhowlett Nov 5, 2020
d9270d1
remove console.logs
willhowlett Nov 5, 2020
c680518
remove liv (reverses https://github.com/dennisinteractive/react-gpt/c…
willhowlett Nov 5, 2020
ae71090
test version
willhowlett Nov 5, 2020
806d7aa
Merge branch 'master' of github.com:dennisinteractive/react-gpt
willhowlett Nov 6, 2020
3597fbe
Merge branch 'master' into APP-1535-optimize-lazyload
willhowlett Nov 6, 2020
f7bf856
update version
willhowlett Nov 6, 2020
8f141d8
reset version
willhowlett Nov 6, 2020
8dbd013
check if element is display:none
willhowlett Nov 10, 2020
4a9a8b0
update test version
willhowlett Nov 10, 2020
c1533f3
bump test version
willhowlett Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
es/
node_modules/
# lib/
lib/
dist/
coverage/
npm-debug.log
Expand Down
1 change: 1 addition & 0 deletions docs/api/ReactGPT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ A React component which renders [GPT](https://support.google.com/dfp_sb/answer/1
- `onSlotOnload`(optional) - An optional event handler function for `googletag.events.SlotOnloadEvent`.
- `renderWhenViewable`(optional) - An optional flag to indicate whether an ad should only render when it's fully in the viewport area.
- `viewableThreshold`(optional) - An optional number to indicate how much percentage of an ad area needs to be in a viewable area before rendering. Acceptable range is between `0` and `1`.
- `viewableTriggerTop`(optional) - An optional percentage figure to trigger render when the ad is x% below the fold.
- `onScriptLoaded`(optional) - An optional call back function to notify when the script is loaded.
- `onMediaQueryChange`(optional) - An optional call back function to notify when the media queries change on the break point specified in the `sizeMapping`.
- `style`(optional) - An optional object to be applied as `style` props to the container div. **This prop is only applied once in initial render.** If you want to apply style to the ad and change it frequently, apply style to the container.
Expand Down
Loading