Fix recurring Linux device, assembly, and shutdown crashes - #94
Open
Jubliano-sama wants to merge 3 commits into
Open
Fix recurring Linux device, assembly, and shutdown crashes#94Jubliano-sama wants to merge 3 commits into
Jubliano-sama wants to merge 3 commits into
Conversation
Jubliano-sama
marked this pull request as ready for review
August 23, 2026 14:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix three independent crash paths observed in the Linux v0.4.0 AppImage:
vue-resize<object>probe used by Mainsail < 2.16.1 and Fluidd < 1.37.0. The workaround is injected at document start and restored afterRemoveAllUserScripts(). This is the reviewed fix from Fix Linux segfault when loading Fluidd/Mainsail printer hosts (#7210) OrcaSlicer/OrcaSlicer#13724 for Segfaults on Linux after connected to Mainsail/fluidd OrcaSlicer/OrcaSlicer#7210.m_assemble_view_dataand itsmodel_objects_clipper()are available. The asynchronous reset callback performs the same lifetime check before dereferencing the clipper.EDITING_DONEevents after application shutdown begins, before the callback can mark an already-reset plater canvas dirty.The changes do not modify Wave Overhangs slicing behavior, presets, translations, or profile formats.
Crash evidence
vue-resizecrash addressed upstream.GLCanvas3D::_render_assemble_control()aftermodel_objects_clipper()returned null.ObjectList::OnEditingDone()->Plater::set_current_canvas_as_dirty()while the application was closing.Screenshots/Recordings/Graphs
Not applicable: these are lifetime and embedded-WebView crash fixes with no intended visual change.
Tests
git diff --check origin/main...HEAD./build_linux.sh -sir -j 6646/646).OrcaSlicer_profile_validatorbuilt successfully.OrcaSlicerWaveOverhangs_Linux_V2.4.0-dev.AppImagesuccessfully.b6dd59cea78081ca1444818fd00850e3adfcc9024f27679d62139cbbac175981No focused unit test currently covers wxGTK teardown event ordering or the embedded WebKit document lifecycle.