fix(check): support jsdoc @import tag (#26991)

* denoland/deno_graph#544 Closes #25516
denoland · Nov 25, 2024 · 2b26444 · 2b26444
1 parent 02b480b
commit 2b26444
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 3 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/cli/Cargo.toml b/cli/Cargo.toml
@@ -73,7 +73,7 @@ deno_cache_dir.workspace = true
 deno_config.workspace = true
 deno_core = { workspace = true, features = ["include_js_files_for_snapshotting"] }
 deno_doc = { version = "0.160.0", features = ["rust", "comrak"] }
-deno_graph = { version = "=0.85.0" }
+deno_graph = { version = "=0.85.1" }
 deno_lint = { version = "=0.68.0", features = ["docs"] }
 deno_lockfile.workspace = true
 deno_npm.workspace = true

diff --git a/tests/specs/check/jsdoc_import_decl/__test__.jsonc b/tests/specs/check/jsdoc_import_decl/__test__.jsonc
@@ -0,0 +1,5 @@
+{
+  "args": "check --allow-import main.js",
+  "output": "check.out",
+  "exitCode": 1
+}
diff --git a/tests/specs/check/jsdoc_import_decl/check.out b/tests/specs/check/jsdoc_import_decl/check.out
@@ -0,0 +1,6 @@
+Download http://localhost:4545/add.ts
+Check file:///[WILDLINE]main.js
+error: TS2345 [ERROR]: Argument of type 'string' is not assignable to parameter of type '(a: number, b: number) => number'.
+addHere("");
+        ~~
+    at file:///[WILDLINE]main.js:12:9
diff --git a/tests/specs/check/jsdoc_import_decl/main.js b/tests/specs/check/jsdoc_import_decl/main.js
@@ -0,0 +1,12 @@
+// @ts-check
+
+/** @import { add } from "http://localhost:4545/add.ts" */
+
+/**
+ * @param {typeof add} myValue
+ */
+export function addHere(myValue) {
+  return myValue(1, 2);
+}
+
+addHere("");