feat(unstable): fast subset type checking of JSR dependencies (#21873)

cli/Cargo.toml

@@ -57,9 +57,9 @@ deno_ast = { workspace = true, features = ["bundler", "cjs", "codegen", "dep_gra
 deno_cache_dir = "=0.6.1"
 deno_config = "=0.6.5"
 deno_core = { workspace = true, features = ["include_js_files_for_snapshotting"] }
-deno_doc = { version = "=0.89.0", features = ["html"] }
+deno_doc = { version = "=0.89.1", features = ["html"] }
 deno_emit = "=0.33.0"
-deno_graph = "=0.63.0"
+deno_graph = "=0.63.2"
 deno_lint = { version = "=0.53.0", features = ["docs"] }
 deno_lockfile.workspace = true
 deno_npm = "=0.15.3"

cli/args/flags.rs

@@ -327,7 +327,6 @@ pub struct VendorFlags {
 
 #[derive(Clone, Debug, Eq, PartialEq)]
 pub struct PublishFlags {
-  pub directory: String,
   pub token: Option<String>,
 }
 
@@ -2372,19 +2371,10 @@ Remote modules and multiple modules may also be specified:
 fn publish_subcommand() -> Command {
   Command::new("publish")
     .hide(true)
-    .about("Unstable preview feature: Publish a package")
+    .about("Unstable preview feature: Publish the current working directory's package or workspace")
     // TODO: .long_about()
     .defer(|cmd| {
       cmd.arg(
-        Arg::new("directory")
-          .help(
-            "The directory to the package, or workspace of packages to publish",
-          )
-          .default_missing_value(".")
-          .value_hint(ValueHint::DirPath)
-          .required(true),
-      )
-      .arg(
         Arg::new("token")
           .long("token")
           .help("The API token to use when publishing. If unset, interactive authentication is be used")
@@ -3821,7 +3811,6 @@ fn vendor_parse(flags: &mut Flags, matches: &mut ArgMatches) {
 
 fn publish_parse(flags: &mut Flags, matches: &mut ArgMatches) {
   flags.subcommand = DenoSubcommand::Publish(PublishFlags {
-    directory: matches.remove_one::<String>("directory").unwrap(),
     token: matches.remove_one("token"),
   });
 }

cli/tests/integration/jsr_tests.rs

@@ -54,6 +54,14 @@ itest!(deps_info {
   http_server: true,
 });
 
+itest!(subset_type_graph {
+  args: "check --all jsr/subset_type_graph/main.ts",
+  output: "jsr/subset_type_graph/main.check.out",
+  envs: env_vars_for_jsr_tests(),
+  http_server: true,
+  exit_code: 1,
+});
+
 itest!(version_not_found {
   args: "run jsr/version_not_found/main.ts",
   output: "jsr/version_not_found/main.out",

cli/tests/integration/publish_tests.rs

@@ -15,21 +15,75 @@ pub fn env_vars_for_registry() -> Vec<(String, String)> {
 }
 
 itest!(no_token {
-  args: "publish publish/missing_deno_json",
+  args: "publish",
+  cwd: Some("publish/missing_deno_json"),
   output: "publish/no_token.out",
   exit_code: 1,
 });
 
 itest!(missing_deno_json {
-  args: "publish --token 'sadfasdf' $TESTDATA/publish/missing_deno_json",
+  args: "publish --token 'sadfasdf'",
   output: "publish/missing_deno_json.out",
+  cwd: Some("publish/missing_deno_json"),
+  copy_temp_dir: Some("publish/missing_deno_json"),
   exit_code: 1,
   temp_cwd: true,
 });
 
+itest!(invalid_fast_check {
+  args: "publish --token 'sadfasdf'",
+  output: "publish/invalid_fast_check.out",
+  cwd: Some("publish/invalid_fast_check"),
+  copy_temp_dir: Some("publish/invalid_fast_check"),
+  exit_code: 1,
+  temp_cwd: true,
+});
+
+itest!(javascript_missing_decl_file {
+  args: "publish --token 'sadfasdf'",
+  output: "publish/javascript_missing_decl_file.out",
+  cwd: Some("publish/javascript_missing_decl_file"),
+  copy_temp_dir: Some("publish/javascript_missing_decl_file"),
+  envs: env_vars_for_registry(),
+  exit_code: 0,
+  temp_cwd: true,
+});
+
+itest!(javascript_decl_file {
+  args: "publish --token 'sadfasdf'",
+  output: "publish/javascript_decl_file.out",
+  cwd: Some("publish/javascript_decl_file"),
+  copy_temp_dir: Some("publish/javascript_decl_file"),
+  envs: env_vars_for_registry(),
+  exit_code: 0,
+  temp_cwd: true,
+});
+
 itest!(successful {
-  args: "publish --token 'sadfasdf' $TESTDATA/publish/successful",
+  args: "publish --token 'sadfasdf'",
   output: "publish/successful.out",
+  cwd: Some("publish/successful"),
+  copy_temp_dir: Some("publish/successful"),
+  envs: env_vars_for_registry(),
+  http_server: true,
+  temp_cwd: true,
+});
+
+itest!(workspace_all {
+  args: "publish --unstable-workspaces --token 'sadfasdf'",
+  output: "publish/workspace.out",
+  cwd: Some("publish/workspace"),
+  copy_temp_dir: Some("publish/workspace"),
+  envs: env_vars_for_registry(),
+  http_server: true,
+  temp_cwd: true,
+});
+
+itest!(workspace_individual {
+  args: "publish --unstable-workspaces --token 'sadfasdf'",
+  output: "publish/workspace_individual.out",
+  cwd: Some("publish/workspace/bar"),
+  copy_temp_dir: Some("publish/workspace"),
   envs: env_vars_for_registry(),
   http_server: true,
   temp_cwd: true,
@@ -43,7 +97,7 @@ fn ignores_directories() {
     "name": "@foo/bar",
     "version": "1.0.0",
     "exclude": [ "ignore" ],
-    "exports": "main_included.ts"
+    "exports": "./main_included.ts"
   }));
 
   let ignored_dirs = vec![
@@ -68,7 +122,6 @@ fn ignores_directories() {
     .arg("--log-level=debug")
     .arg("--token")
     .arg("sadfasdf")
-    .arg(temp_dir)
     .run();
   output.assert_exit_code(0);
   let output = output.combined_output();
@@ -81,4 +134,5 @@ fn publish_context_builder() -> TestContextBuilder {
   TestContextBuilder::new()
     .use_http_server()
     .envs(env_vars_for_registry())
+    .use_temp_cwd()
 }

cli/tests/testdata/jsr/registry/@denotest/subset_type_graph/0.1.0/mod.ts

@@ -0,0 +1,17 @@
+// add some statements that will be removed by the subset
+// type graph so that we can test that the source map works
+console.log(1);
+console.log(2);
+console.log(3);
+
+export class Foo {
+  method(): number {
+    return Math.random();
+  }
+}
+
+// this won't be type checked against because the subset
+// type graph omit this code because it's not part of the
+// public API.
+const invalidTypeCheck: number = "";
+console.log(invalidTypeCheck);

cli/tests/testdata/jsr/registry/@denotest/subset_type_graph/0.1.0_meta.json

@@ -0,0 +1,5 @@
+{
+  "exports": {
+    ".": "./mod.ts"
+  }
+}

cli/tests/testdata/jsr/registry/@denotest/subset_type_graph/meta.json

@@ -0,0 +1,5 @@
+{
+  "versions": {
+    "0.1.0": {}
+  }
+}

cli/tests/testdata/jsr/registry/@denotest/subset_type_graph_invalid/0.1.0/mod.ts

@@ -0,0 +1,12 @@
+export class Foo {
+  method() {
+    return Math.random();
+  }
+}
+
+// This will be analyzed because the method above is missing an
+// explicit type which is required for the subset type graph to take
+// effect. So the entire source file will be type checked against,
+// causing a type error here.
+const invalidTypeCheck: number = "";
+console.log(invalidTypeCheck);

cli/tests/testdata/jsr/registry/@denotest/subset_type_graph_invalid/0.1.0_meta.json

@@ -0,0 +1,5 @@
+{
+  "exports": {
+    ".": "./mod.ts"
+  }
+}

cli/tests/testdata/jsr/registry/@denotest/subset_type_graph_invalid/meta.json

@@ -0,0 +1,5 @@
+{
+  "versions": {
+    "0.1.0": {}
+  }
+}

cli/tests/testdata/jsr/subset_type_graph/main.check.out

@@ -0,0 +1,45 @@
+Download http://localhost:4545/jsr/registry/@denotest/subset_type_graph/meta.json
+Download http://localhost:4545/jsr/registry/@denotest/subset_type_graph_invalid/meta.json
+Download http://localhost:4545/jsr/registry/@denotest/subset_type_graph/0.1.0_meta.json
+Download http://localhost:4545/jsr/registry/@denotest/subset_type_graph_invalid/0.1.0_meta.json
+[UNORDERED_START]
+Download http://localhost:4545/jsr/registry/@denotest/subset_type_graph/0.1.0/mod.ts
+Download http://localhost:4545/jsr/registry/@denotest/subset_type_graph_invalid/0.1.0/mod.ts
+[UNORDERED_END]
+Check file:///[WILDCARD]/subset_type_graph/main.ts
+error: TS2322 [ERROR]: Type 'string' is not assignable to type 'number'.
+const invalidTypeCheck: number = "";
+      ~~~~~~~~~~~~~~~~
+    at http://localhost:4545/jsr/registry/@denotest/subset_type_graph_invalid/0.1.0/mod.ts:11:7
+
+TS2322 [ERROR]: Type 'number' is not assignable to type 'string'.
+const error1: string = new Foo1().method();
+      ~~~~~~
+    at file:///[WILDCARD]/subset_type_graph/main.ts:5:7
+
+TS2322 [ERROR]: Type 'number' is not assignable to type 'string'.
+const error2: string = new Foo2().method();
+      ~~~~~~
+    at file:///[WILDCARD]/subset_type_graph/main.ts:6:7
+
+TS2551 [ERROR]: Property 'method2' does not exist on type 'Foo'. Did you mean 'method'?
+new Foo1().method2();
+           ~~~~~~~
+    at file:///[WILDCARD]/subset_type_graph/main.ts:12:12
+
+    'method' is declared here.
+      method(): number {
+      ~~~~~~
+        at http://localhost:4545/jsr/registry/@denotest/subset_type_graph/0.1.0/mod.ts:8:3
+
+TS2551 [ERROR]: Property 'method2' does not exist on type 'Foo'. Did you mean 'method'?
+new Foo2().method2();
+           ~~~~~~~
+    at file:///[WILDCARD]/subset_type_graph/main.ts:13:12
+
+    'method' is declared here.
+      method() {
+      ~~~~~~
+        at http://localhost:4545/jsr/registry/@denotest/subset_type_graph_invalid/0.1.0/mod.ts:2:3
+
+Found 5 errors.

cli/tests/testdata/jsr/subset_type_graph/main.ts

@@ -0,0 +1,13 @@
+import { Foo as Foo1 } from "jsr:@denotest/[email protected]";
+import { Foo as Foo2 } from "jsr:@denotest/[email protected]";
+
+// these will both raise type checking errors
+const error1: string = new Foo1().method();
+const error2: string = new Foo2().method();
+console.log(error1);
+console.log(error2);
+
+// now raise some errors that will show the original code and
+// these should source map to the original
+new Foo1().method2();
+new Foo2().method2();

cli/tests/testdata/publish/invalid_fast_check.out

@@ -0,0 +1,8 @@
+Checking fast check type graph for errors...
+
+Missing explicit return type in the public API.
+    at file:///[WILDCARD]/publish/invalid_fast_check/mod.ts:2:17
+
+Fixing these fast check errors is required to make the code fast check compatible which enables type checking your package's TypeScript code with the same performance as if you had distributed declaration files. Do any of these errors seem too restrictive or incorrect? Please open an issue if so to help us improve: https://github.com/denoland/deno/issues
+
+error: Had 1 fast check error.

cli/tests/testdata/publish/invalid_fast_check/deno.json

@@ -0,0 +1,7 @@
+{
+  "name": "@foo/bar",
+  "version": "1.1.0",
+  "exports": {
+    ".": "./mod.ts"
+  }
+}

cli/tests/testdata/publish/invalid_fast_check/mod.ts

@@ -0,0 +1,4 @@
+// requires an explicit type annotation of `number`
+export function getRandom() {
+  return Math.random();
+}

cli/tests/testdata/publish/javascript_decl_file.out

@@ -0,0 +1,6 @@
+Checking fast check type graph for errors...
+Ensuring type checks...
+Check file:///[WILDCARD]/javascript_decl_file/mod.js
+Publishing @foo/[email protected] ...
+Successfully published @foo/[email protected]
+Visit http://127.0.0.1:4250/@foo/[email protected] for details

cli/tests/testdata/publish/javascript_decl_file/deno.json

@@ -0,0 +1,7 @@
+{
+  "name": "@foo/bar",
+  "version": "1.0.0",
+  "exports": {
+    ".": "./mod.js"
+  }
+}

cli/tests/testdata/publish/javascript_decl_file/mod.d.ts

@@ -0,0 +1 @@
+export function getRandom(): number;

cli/tests/testdata/publish/javascript_decl_file/mod.js

@@ -0,0 +1,5 @@
+/// <reference types="./mod.d.ts" />
+
+export function getRandom() {
+  return Math.random();
+}

cli/tests/testdata/publish/javascript_missing_decl_file.out

@@ -0,0 +1,6 @@
+Checking fast check type graph for errors...
+Warning Package '@foo/bar' is a JavaScript package without a corresponding declaration file. This may lead to a non-optimal experience for users of your package. For performance reasons, it's recommended to ship a corresponding TypeScript declaration file or to convert to TypeScript.
+Ensuring type checks...
+Publishing @foo/[email protected] ...
+Successfully published @foo/[email protected]
+Visit http://127.0.0.1:4250/@foo/[email protected] for details

cli/tests/testdata/publish/javascript_missing_decl_file/deno.json

@@ -0,0 +1,8 @@
+{
+  "name": "@foo/bar",
+  "version": "1.0.0",
+  "exports": {
+    ".": "./mod.js",
+    "./other": "./other.js"
+  }
+}

cli/tests/testdata/publish/javascript_missing_decl_file/mod.js

@@ -0,0 +1,3 @@
+export function getRandom() {
+  return Math.random();
+}

cli/tests/testdata/publish/javascript_missing_decl_file/other.js

@@ -0,0 +1,3 @@
+export function other() {
+  return Math.random();
+}

cli/tests/testdata/publish/missing_deno_json/main.ts

@@ -0,0 +1,3 @@
+export function add(a: number, b: number): number {
+  return a + b;
+}

cli/tests/testdata/publish/successful.out

@@ -1,3 +1,6 @@
+Checking fast check type graph for errors...
+Ensuring type checks...
+Check file:///[WILDCARD]/publish/successful/mod.ts
 Publishing @foo/[email protected] ...
 Successfully published @foo/[email protected]
 Visit http://127.0.0.1:4250/@foo/[email protected] for details

cli/tests/testdata/publish/successful/deno.json

@@ -5,6 +5,6 @@
     ".": "./mod.ts"
   },
   "imports": {
-    "@std/http": "jsr:@std/http@1"
+    "@std/http": "./std_http.ts"
   }
 }

cli/tests/testdata/publish/successful/mod.ts

@@ -1,5 +1,5 @@
 import http from "@std/http";
 
-export function foobar() {
+export function foobar(): { fileServer(): void } {
   return http.fileServer;
 }