tests: enable package_json_node_modules_none (#25825)

Co-authored-by: David Sherret <[email protected]>
denoland · Oct 4, 2024 · 7b509e4 · 7b509e4
1 parent edac916
commit 7b509e4
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 20 deletions.
diff --git a/tests/integration/task_tests.rs b/tests/integration/task_tests.rs
@@ -18,19 +18,6 @@
 //   http_server: true,
 // });
 
-// TODO(2.0): decide what to do with this test
-// should not auto-install the packages in the package.json
-// when using nodeModulesDir: false
-// itest!(task_package_json_node_modules_dir_false {
-//   args: "task echo",
-//   cwd: Some("task/package_json_node_modules_dir_false/"),
-//   output: "task/package_json_node_modules_dir_false/bin.out",
-//   copy_temp_dir: Some("task/package_json_node_modules_dir_false/"),
-//   envs: env_vars_for_npm_tests(),
-//   exit_code: 0,
-//   http_server: true,
-// });
-
 // TODO(2.0): not entirely clear what's wrong with this test but it hangs for more than 60s
 // itest!(task_npx_on_own {
 //   args: "task on-own",

diff --git a/tests/specs/task/package_json_node_modules_dir_none/__test__.jsonc b/tests/specs/task/package_json_node_modules_dir_none/__test__.jsonc
@@ -0,0 +1,6 @@
+{
+  "tempDir": true,
+  "args": "task echo",
+  "output": "bin.out",
+  "exitCode": 0
+}
diff --git a/tests/specs/task/package_json_node_modules_dir_none/bin.out b/tests/specs/task/package_json_node_modules_dir_none/bin.out
@@ -0,0 +1,8 @@
+[UNORDERED_START]
+Download http://localhost:4260/@denotest/bin
+Download http://localhost:4260/@denotest/bin/1.0.0.tgz
+Download http://localhost:4260/@denotest/bin/0.5.0.tgz
+[UNORDERED_END]
+Task echo deno eval 'console.log(1)' && cli-esm hi
+1
+hi
diff --git a/tests/specs/task/package_json_node_modules_dir_none/deno.json b/tests/specs/task/package_json_node_modules_dir_none/deno.json
@@ -0,0 +1,3 @@
+{
+  "nodeModulesDir": "none"
+}
diff --git a/..._json_node_modules_dir_false/package.json → ...e_json_node_modules_dir_none/package.json b/..._json_node_modules_dir_false/package.json → ...e_json_node_modules_dir_none/package.json
@@ -1,6 +1,6 @@
 {
   "scripts": {
-    "echo": "deno eval 'console.log(1)'"
+    "echo": "deno eval 'console.log(1)' && cli-esm hi"
   },
   "dependencies": {
     "@denotest/bin": "0.5",

diff --git a/tests/testdata/task/package_json_node_modules_dir_false/bin.out b/tests/testdata/task/package_json_node_modules_dir_false/bin.out
diff --git a/tests/testdata/task/package_json_node_modules_dir_false/deno.json b/tests/testdata/task/package_json_node_modules_dir_false/deno.json
diff --git a/tools/lint.js b/tools/lint.js
@@ -220,7 +220,7 @@ async function ensureNoNewITests() {
     "repl_tests.rs": 0,
     "run_tests.rs": 331,
     "shared_library_tests.rs": 0,
-    "task_tests.rs": 3,
+    "task_tests.rs": 2,
     "test_tests.rs": 0,
     "upgrade_tests.rs": 0,
     "vendor_tests.rs": 1,