fix(lsp): show dependency errors for repeated imports#18807
Merged
dsherret merged 6 commits intodenoland:mainfrom Apr 24, 2023
Merged
fix(lsp): show dependency errors for repeated imports#18807dsherret merged 6 commits intodenoland:mainfrom
dsherret merged 6 commits intodenoland:mainfrom
Conversation
Member
|
@nayeemrmn could you bump |
dsherret
reviewed
Apr 24, 2023
Member
dsherret
left a comment
dsherret
left a comment
There was a problem hiding this comment.
Looks good. Just needs a few small changes.
| "file:///a.ts", | ||
| r#" | ||
| import "bad.js"; | ||
| import "bad.js"; |
Member
There was a problem hiding this comment.
Maybe try adding a test with multiple bad @deno-types directives as well?
Contributor
Author
There was a problem hiding this comment.
Only one @deno-types directive is stored per JS dep, that would be addressed by denoland/deno_graph#272 Edit: actually no it should ignore @deno-types for deps which already have one attached.
…-duplicate-imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missing because
deno_graphdidn't store every import site for a dependency until denoland/deno_graph#251.Before
After