feat: add --open to deno serve to open server in browser #25340
Conversation
|
@marvinhagemeister @dsherret Is there a workaround or should I just remove the test? |
|
@bartlomieju @marvinhagemeister |
| @@ -2875,7 +2877,7 @@ Start a server defined in server.ts, watching for changes and running on port 50 | |||
| .long("host") | |||
| .help("The TCP address to serve on, defaulting to 0.0.0.0 (all interfaces)") | |||
| .value_parser(serve_host_validator), | |||
| ) | |||
| ).arg(Arg::new("open_site").long("open").help("Open the browser on the address that the server is running on.").action(ArgAction::SetTrue)) | |||
There was a problem hiding this comment.
Did you run tools/format.js before pushing? This seems not formatted
There was a problem hiding this comment.
yes I did, and did it again now, still the same.
cli/tools/serve.rs
Outdated
| log::info!( | ||
| "{}: Opened the browser on the address that the server is running on", | ||
| crate::colors::green("deno serve") | ||
| ); | ||
| } else { | ||
| log::info!("{}: Couldn't open the browser on the address that the server is running on", crate::colors::red("deno serve")); | ||
| } |
There was a problem hiding this comment.
I'm not sure if it worth adding these logs here, does Vite or other tools do it?
There was a problem hiding this comment.
I checked Vite, it doesn't log on success, but logs "e.g. (Permission denied)" on failure.
Deno already shows logs on failure of serve, so you're right. No need for these logs
tests/integration/serve_tests.rs
Outdated
|
|
||
| // Check if a new browser tab has been opened by checking | ||
| // stderr includes the target output expected | ||
| fn check_tab_opened(&self) { |
There was a problem hiding this comment.
I'm not sure if this test makes sense - on CI there will be no browser to open, while locally people will suddenly get some new tabs. I'd suggest to not add it at all.
…/deno into open-flag-on-serve
|
@bartlomieju |
|
@bartlomieju |
|
Bumping this ^ @bartlomieju |
This PR addresses issue number #25149
Change:
Supported --open flag with deno serve -> (deno serve --open somescript.ts/js).
The action that takes place is openning the browser on the address that the server is running on.
Changes on code:
Concerns:
The window tab will be opened on deno serve command no matter whether deno serve succeeds or fails.
The added test since it's a serve command then it starts listening for a request and never shuts down, I couldn't figure out how to shut it down same as other serve tests.