Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/crypto): fix identity test for x25519 derive bits #26011

Merged
merged 2 commits into from
Oct 3, 2024
Merged

fix(ext/crypto): fix identity test for x25519 derive bits #26011

merged 2 commits into from
Oct 3, 2024
+46 −70

Conversation

littledivy
Copy link
Member

Fixes #25991

lucacasonato
lucacasonato approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@littledivy littledivy merged commit e54809f into denoland:main Oct 3, 2024
17 checks passed
@littledivy littledivy deleted the fix_x25519_derive_bits branch October 3, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using deriveBits (std/crypto) with x25519 crashes
2 participants
@littledivy @lucacasonato