Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools/installer): Fix DENO_INSTALL_ROOT #26446

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

dovakin0007
Copy link
Contributor

@dovakin0007 dovakin0007 commented Oct 21, 2024

This PR fixes the issue where the PathBuf appends /bin even if bin dir already exists referenced in this issue
#26442

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2024

CLA assistant check
All committers have signed the CLA.

@bartlomieju
Copy link
Member

Is there a test you could that that exercises this change? You could put it in tests/integration/install_tests.rs

@dovakin0007
Copy link
Contributor Author

dovakin0007 commented Nov 15, 2024

Is there a test you could that that exercises this change? You could put it in tests/integration/install_tests.rs

let me try to do that then!

@dovakin0007
Copy link
Contributor Author

dovakin0007 commented Nov 15, 2024

Is there a test you could that that exercises this change? You could put it in tests/integration/install_tests.rs

should I create a new test case or modifying an existing test case is fine? right now I modified an existing test case

  • before
    image

  • after
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants