fix(ext/http): registerDeclarativeServer #26606
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Added test case for registerDeclarativeServer like we discussed over email
test of registerdeclarativeserver changes
bartlomieju
reviewed
Oct 29, 2024
bartlomieju
reviewed
Oct 29, 2024
| @@ -882,7 +882,7 @@ function registerDeclarativeServer(exports) { | |||
| : ""; | |||
| const host = formatHostName(hostname); | |||
|
|
|||
| // deno-lint-ignore no-console | |||
| // Log server information | |||
There was a problem hiding this comment.
You will need to keep the previous lint supression here
There was a problem hiding this comment.
This comment is still relevant and the CI won't pass unless it's addressed
bartlomieju
reviewed
Oct 29, 2024
Comment on lines
1
to
3
| export const fetch = (req: Request) => { | ||
| return new Response("Hello from declarative server!"); | ||
| }; |
There was a problem hiding this comment.
We don't support this syntax (yet!), so you'll need something like this:
export default {
fetch(req: Request) {
return new Response("Hello from declarative server");
},
onListen(info) {
console.log(info);
}
} satisfies Deno.ServeDefaultExport;
Co-authored-by: Bartek Iwańczuk <[email protected]> Signed-off-by: ricfrst <[email protected]>
Signed-off-by: ricfrst <[email protected]>
Signed-off-by: ricfrst <[email protected]>
bartlomieju
reviewed
Nov 4, 2024
cli/tsc/dts/lib.deno.ns.d.ts
Outdated
Comment on lines
1211
to
1212
| /** Interface for serving HTTP requests. */ | ||
| interface ServeDefaultExport { |
There was a problem hiding this comment.
Looks like we got two ServeDefaultExport now :D can you please move onListen declaration to the existing interface on line 5068?
Signed-off-by: ricfrst <[email protected]>
Signed-off-by: ricfrst <[email protected]>
bartlomieju
reviewed
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to registerDeclarativeServer as discussed over our call