fix(publish): improve error message when missing exports #26945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Nov 19, 2024
| let deno_json = &package.config_file; | ||
| let config_path = deno_json.specifier.to_file_path().unwrap(); | ||
| let root_dir = config_path.parent().unwrap().to_path_buf(); | ||
| let Some(version) = deno_json.json.version.clone() else { | ||
| bail!("{} is missing 'version' field", deno_json.specifier); | ||
| }; | ||
| if deno_json.json.exports.is_none() { |
There was a problem hiding this comment.
This code was not tested and never hit.
bartlomieju
approved these changes
Nov 20, 2024
| ); | ||
|
|
||
| bail!( | ||
| "You did not specify an entrypoint in {}. Add `exports` mapping in the configuration file, eg:\n{}", |
There was a problem hiding this comment.
Link to the some docs here?
There was a problem hiding this comment.
Also wished we could do info/hint here for nice human-readable output.
There was a problem hiding this comment.
I'm just going to merge because it's better than before and I have to go somewhere :D (and will focus on TypeScript upgrade tomorrow)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.