Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(task): support --filter #26949

Merged
merged 9 commits into from
Nov 20, 2024
Merged

feat(task): support --filter #26949

merged 9 commits into from
Nov 20, 2024

Conversation

marvinhagemeister
Copy link
Contributor

@marvinhagemeister marvinhagemeister commented Nov 20, 2024 •
edited by bartlomieju
Loading

Closes #24991

@bartlomieju bartlomieju marked this pull request as ready for review November 20, 2024 20:45
@bartlomieju @nathanwhit
Update cli/args/flags.rs
2aef160 
Co-authored-by: Nathan Whitaker <[email protected]>
Signed-off-by: Bartek Iwańczuk <[email protected]>
nathanwhit
nathanwhit reviewed Nov 20, 2024
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should actually make --filter imply --recursive (i believe that's what pnpm does)

cli/tools/task.rs Outdated Show resolved Hide resolved
marvinhagemeister
marvinhagemeister commented Nov 20, 2024
View reviewed changes
tests/specs/task/filter/deno_workspace_order.out
Task dev echo '@foo/bar'
@foo/bar
Task dev echo '@foo/baz'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: I need to take a look at these tomorrow. I think the order of tasks is wrong here but maybe I made it too confusing with the fixtures.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They didn't seem to depend on each other, and I believe were printed in reversed order

Copy link
Contributor Author

@marvinhagemeister marvinhagemeister Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tasks itself don't yeah, but the packages do. When package A depends on B, the matching tasks from B must be executed first.

@dsherret @nathanwhit
Update cli/tools/task.rs
f516d0a 
Co-authored-by: Nathan Whitaker <[email protected]>
Signed-off-by: David Sherret <[email protected]>
@bartlomieju bartlomieju mentioned this pull request Nov 20, 2024
Closed
2 tasks
dsherret
dsherret reviewed Nov 20, 2024
View reviewed changes
cli/tools/task.rs Outdated Show resolved Hide resolved
bartlomieju
bartlomieju approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit f0b245c into main Nov 20, 2024
17 checks passed
@bartlomieju bartlomieju deleted the task-workspace-filter branch November 20, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

@nathanwhit nathanwhit nathanwhit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno workspace: --filter or -r (recursive)
4 participants
@marvinhagemeister @dsherret @bartlomieju @nathanwhit