refactor: object wrap WebGPU #27665
Open
refactor: object wrap WebGPU #27665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crowlKats |
|
@jlucaso1 I am aware; we actually likely wont land this PR in this repo for the time being as we still figure out problems with object wrap, but rather will land it directly in the wgpu repo (in the |
# Conflicts: # Cargo.lock
# Conflicts: # ext/webgpu/lib.rs
# Conflicts: # Cargo.lock
Signed-off-by: Leo Kettmeir <[email protected]>
|
Looks good at a glance. Can you update the PR description with binary size increase? |
|
@petamoriken yes it does, since there arent resources anymore so saniters arent a concern anymore! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened denoland/webgpu-examples#19 as well.
Fixes #25874
Fixes #26760
Fixes #24288
Fixes #24798
Fixes #25627
Fixes #25915
Fixes #26769
Binary size increase: 897kb