feat: TypeScript 5.7 #27857
feat: TypeScript 5.7 #27857
Conversation
…was previously created in the @types/node pkg
cli/tsc/dts/lib.dom.d.ts
Outdated
There was a problem hiding this comment.
Unfortunately the lib.dom types haven't been updated to use typed arrays. This is going to be a painful transition, but I think it's probably best for us to keep aligning with TypeScript.
| const setTypesNodeIgnorableNames = new Set([ | ||
| "AbortController", | ||
| "AbortSignal", | ||
| "AsyncIteratorObject", | ||
| "atob", | ||
| "Blob", |
There was a problem hiding this comment.
How did you generate that list?
There was a problem hiding this comment.
I added logging for whenever the @types/node project assigned to a global then put everything in here then deleted the ones I didn't think were necessary. Probably some of these could still be removed. It actually might be better for us to use an allow list, but I'm not sure.
There was a problem hiding this comment.
I'm more worried about getting this list again in X months.
There was a problem hiding this comment.
Let's see how this goes. I mostly just kept it to anything that was causing errors with our globals so maybe we can remove or add to this over time based on feedback and errors we encounter when upgrading.
There was a problem hiding this comment.
Are these changes intentional?
There was a problem hiding this comment.
Yeah, I was lazy :)
I trimmed these out when updating the local @types/node package.
There was a problem hiding this comment.
Ditto, seems like a lot of noise
The generic typed array changes are extremely painful.
Includes: denoland/TypeScript#15 (https://github.com/denoland/TypeScript/pull/15/files/bf17c62cfd79ca3f2dca413f7f666708d7ec0deb..e3e34dbc130e3f08227e5245658a3c3b821f16fe)
Closes #26950