-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ext/node): better dns.lookup compatibility #27936
Open
kt3k
wants to merge
12
commits into
denoland:main
Choose a base branch
from
kt3k:fix-node-dns-use-gai-resolver
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c52102f
to
99e4206
Compare
99e4206
to
1d63322
Compare
9b61e7d
to
933b5a4
Compare
I'll also try to implement net permission checks for dns.lookup (op_getaddrinfo) (which checks the net permission with hostnames, not name servers or config files). |
da43e90
to
6480e07
Compare
6480e07
to
d0a4740
Compare
bc43984
to
9cde2d9
Compare
12435f9
to
9eb2828
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the implementation of dns.lookup (of node compat) to use
getaddrinfo
(GaiResolver) instead of hickory-dns. This should provide more compatibility for the edge cases like #27670, etc as Node.js also usesgetaddrinfo
internally.This fixes #27670
This could possibly have effect to #27642, #27384, and #27803
This PR also fixes the permission requirement for
net.connect(hostname)
andhttp.request("http://" + hostname)
. Currently we require net permission to DNS name servers, and also net permission to resolved IP addresses. However that is very different from net permission requirement forfetch
API call (This caused the issue #27634). Now this change requires net permission to hostname atdns.lookup
call and that call implicitly gives net permission of resolved IP addresses. With these changes, the permission requirement forhttp.request(url)
is now the same asfetch(url)
.This fixes #27634
Remaining:
op_getaddrinfo
happens in unit_node/http_test in a flaky wayport large dns response test from fix(ext/net): enable EDNS0 for Deno.resolveDns #27735http(s).request