Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove one of 'node_unit_tests::tls_test' tests #27985

Merged
merged 3 commits into from
Feb 6, 2025
Merged

test: remove one of 'node_unit_tests::tls_test' tests #27985

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca3436b
test: change 'node_unit_tests::tls_test' to use local server
bartlomieju Feb 5, 2025
84af3f7
remove
bartlomieju Feb 6, 2025
ce9c3b1
lint
bartlomieju Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions tests/unit_node/tls_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import { fromFileUrl, join } from "@std/path";
import * as tls from "node:tls";
import * as net from "node:net";
import * as stream from "node:stream";
import { text } from "node:stream/consumers";
import { execCode } from "../unit/test_util.ts";

const tlsTestdataDir = fromFileUrl(
Expand Down Expand Up @@ -98,18 +97,6 @@ Connection: close
assertEquals(bodyText, "hello");
});

// Regression at https://github.com/denoland/deno/issues/27652
Deno.test("tls.connect makes tls connection to example.com", async () => {
const socket = tls.connect(443, "example.com");
await new Promise((resolve) => {
socket.on("secureConnect", resolve);
});
socket.write(
"GET / HTTP/1.1\r\nHost: example.com\r\nConnection: close\r\n\r\n",
);
assertStringIncludes(await text(socket), "<title>Example Domain</title>");
});

// https://github.com/denoland/deno/pull/20120
Deno.test("tls.connect mid-read tcp->tls upgrade", async () => {
const { promise, resolve } = Promise.withResolvers<void>();
Expand Down