Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ deno_core = { version = "0.341.0" }
deno_bench_util = { version = "0.190.0", path = "./bench_util" }
deno_config = { version = "=0.51.0", features = ["workspace"] }
deno_doc = "=0.169.1"
deno_graph = "=0.89.3"
deno_graph = "=0.89.4"
deno_lint = "=0.74.0"
deno_lockfile = "=0.25.0"
deno_media_type = { version = "=0.2.8", features = ["module_specifier"] }
Expand Down
8 changes: 8 additions & 0 deletions cli/graph_util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ use std::error::Error;
use std::path::PathBuf;
use std::sync::Arc;

use deno_ast::MediaType;
use deno_config::deno_json;
use deno_config::deno_json::CompilerOptionTypesDeserializeError;
use deno_config::deno_json::NodeModulesDirMode;
Expand Down Expand Up @@ -1170,6 +1171,13 @@ fn get_resolution_error_bare_specifier(
}

fn get_import_prefix_missing_error(error: &ResolutionError) -> Option<&str> {
// not exact, but ok because this is just a hint
let media_type =
MediaType::from_specifier_and_headers(&error.range().specifier, None);
if media_type == MediaType::Wasm {
return None;
}

let mut maybe_specifier = None;
if let ResolutionError::InvalidSpecifier {
error: SpecifierError::ImportPrefixMissing { specifier, .. },
Expand Down
5 changes: 5 additions & 0 deletions tests/specs/run/error_bad_wasm_import/__test__.jsonc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"args": "run main.js",
"exitCode": 1,
"output": "main.out"
}
3 changes: 3 additions & 0 deletions tests/specs/run/error_bad_wasm_import/main.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { getValue } from "./toolkit.wasm";

console.log(getValue());
2 changes: 2 additions & 0 deletions tests/specs/run/error_bad_wasm_import/main.out
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
error: Relative import path "env" not prefixed with / or ./ or ../
at file:///[WILDLINE]/toolkit.wasm:1:65
Binary file added tests/specs/run/error_bad_wasm_import/toolkit.wasm
Binary file not shown.
7 changes: 7 additions & 0 deletions tests/specs/run/error_bad_wasm_import/toolkit.wat
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
(module
(import "env" "get_time_in_seconds" (func $get_time (result i32)))

(func (export "getValue") (result i32)
call $get_time
)
)