Skip to content

fix(compile): panic when compiled with --no-terminal flag #28823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 29, 2025
Merged

fix(compile): panic when compiled with --no-terminal flag #28823

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4bd888c
Fix stdin when used with --no-terminal
JasperVanEsveld Apr 10, 2025
ba83e24
Format changes
JasperVanEsveld Apr 10, 2025
1628ec6
Fix linting issue
JasperVanEsveld Apr 10, 2025
2348a65
Merge branch 'denoland:main' into main
JasperVanEsveld Apr 27, 2025
d909e65
Add back line that ends stdin's dummy stream
JasperVanEsveld Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ext/node/ops/util.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,18 @@ enum HandleType {
}

#[op2(fast)]
pub fn op_node_guess_handle_type(
state: &mut OpState,
rid: u32,
) -> Result<u32, deno_core::error::ResourceError> {
let handle = state.resource_table.get_handle(rid)?;
pub fn op_node_guess_handle_type(state: &mut OpState, rid: u32) -> u32 {
let handle = match state.resource_table.get_handle(rid) {
Ok(handle) => handle,
_ => return HandleType::Unknown as u32,
};

let handle_type = match handle {
ResourceHandle::Fd(handle) => guess_handle_type(handle),
_ => HandleType::Unknown,
};

Ok(handle_type as u32)
handle_type as u32
}

#[cfg(windows)]
Expand Down
Loading