fix(ext/http): require genuine Response returned from Deno.serve
#29106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct `rawHeaders` structure Fixes #28022 Previously, when a user manipulated the global `Response` object, we would use that object when passing the response from the Node shim to `Deno.serve`. This caused issues when the user manipulated the `Response` object in a way that would break `Deno.serve`. The raw headers bug is that we were exposing the `rawHeaders` field on `Incoming` as a `Headers` object, instead it's supposed to be a flat array of the header keys + values. I.e. `["Content-Type:", "application/json", "Host:", "http://localhost"]` Co-authored-by: Nathan Whitaker <[email protected]>
lucacasonato
changed the title
Response returned from Deno.serveResponse returned from Deno.serve
lucacasonato
force-pushed
the
deno_serve_cleanup
branch
from
621805c to
9cbb16c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #29105 and #29056.
Deno.serveshould have been checking for genuineResponseobjects using aninternal slot check, not using prototype checks.