fix(upgrade): skip version comparison when upgrading #29112
+10
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the version upgrade logic by skipping semantic version comparisons and instead relying on simple string equality and a release channel check.
- Removed semver parsing and comparison for non-Canary channels
- Simplified the upgrade condition logic using a boolean flag (should_upgrade)
Comments suppressed due to low confidence (1)
cli/tools/upgrade.rs:760
- The removal of semantic version parsing and comparison for Stable, Lts, and Rc channels now relies solely on string equality and a release channel check, which may lead to upgrades even when the current version is semantically newer if formatting differs. Please verify that this behavior is intended for all upgrade scenarios.
version::DENO_VERSION_INFO.deno
marvinhagemeister
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Deno 2.3.0, the version was accidentally released as
2.4.0. This was fixed in 2.3.1. Now anyone who upgraded to 2.3.0 can't rundeno upgradeto upgrade to 2.3.1 because of this upgrade behaviour. It would be better to just always go to the latest remote specified version when someone runsdeno upgrade.This also fixes a bug outlined in #29016
Closes #29016