Skip to content

fix(check): disable diagnostic for 'file differs only in casing' #29133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nayeemrmn
Copy link
Contributor

Fixes denoland/vscode_deno#903. This issue is actually caused by VSCode discretely 'opening' files that are renamed and sometimes keeping the old name. But this diagnostic is irrelevant to Deno's module loading so let's suppress it.

@nayeemrmn nayeemrmn requested review from dsherret and nathanwhit May 2, 2025 05:15
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally like and use this diagnostic (it also helps against accidentally publishing code that won't work once remote). Maybe we should only disable this for the lsp?

@nayeemrmn nayeemrmn closed this May 8, 2025
@nayeemrmn nayeemrmn deleted the check-lsp-file-casing branch May 9, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Already included file name: file with customs extension
2 participants