Skip to content

fix(lsp): use correct resolution kind when checking for no-export-npm #29180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2025
Merged

fix(lsp): use correct resolution kind when checking for no-export-npm #29180

merged 3 commits into from
May 8, 2025

Conversation

nayeemrmn
Copy link
Contributor

Fixes #29177.

@nayeemrmn nayeemrmn requested review from dsherret and nathanwhit May 6, 2025 15:01
nathanwhit
nathanwhit approved these changes May 8, 2025
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit fc74cfe into denoland:main May 8, 2025
18 checks passed
@nayeemrmn nayeemrmn deleted the lsp-npm-missing-types-no-diagnostic branch May 8, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-export-npm diagnostic for untyped npm packages
2 participants
@nayeemrmn @nathanwhit