Skip to content

fix(ext/node): support http over unix sockets #29182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 8, 2025
Merged

Conversation

satyarohith
Copy link
Member

@satyarohith satyarohith commented May 6, 2025

Co-authored-by: Divy Srivastava [email protected]

Closes #20255

@satyarohith satyarohith added the ci-draft Run the CI on draft PRs. label May 6, 2025
@littledivy
Copy link
Member

Todo: need to fix resource leaks noticed by Deno.test

@satyarohith satyarohith marked this pull request as ready for review May 6, 2025 16:58
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy removed the ci-draft Run the CI on draft PRs. label May 8, 2025
@littledivy littledivy merged commit 5f13991 into main May 8, 2025
18 checks passed
@littledivy littledivy deleted the http_over_unix_socket branch May 8, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm:docker-modem doesn't work (and @testcontainers/* as a result)
3 participants