Skip to content

feat(experiment): deno:request event in node:http #30746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CertainLach wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(experiment): deno:request event in node:http #30746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ext/node/polyfills/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2009,6 +2009,12 @@ function _addAbortSignalOption(server: ServerImpl, options: ListenOptions) {
}
}

export class DenoRequestEvent {
Copy link
Contributor Author

@CertainLach CertainLach Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to use extends Event there so that users would use typical e.preventDefault() pattern, but it seems strange to mix node's EventEmitted with browser events.

It would also require both setting pendingResponse and cancelling the event, instead of just setting the response field

pendingResponse?: Promise<Response> | Response;

constructor(public req: Request) {}
}

export class ServerImpl extends EventEmitter {
#addr: Deno.NetAddr | null = null;
#hasClosed = false;
Expand Down Expand Up @@ -2077,6 +2083,12 @@ export class ServerImpl extends EventEmitter {
_serve() {
const ac = new AbortController();
const handler = (request: Request, info: Deno.ServeHandlerInfo) => {
const denoEv = new DenoRequestEvent(request);
this.emit("deno:request", denoEv);
if (denoEv.pendingResponse) {
return denoEv.pendingResponse;
}

const socket = new FakeSocket({
remoteAddress: info.remoteAddr.hostname,
remotePort: info.remoteAddr.port,
Expand Down
Loading