fix: queue dynamic imports for modules with pending TLA #31670
Merged
+42
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29123
Related denoland/deno_core#1149
Needs:
When a module with Top-Level Await (TLA) is dynamically imported multiple times before the TLA resolves, subsequent imports would fail with "Cannot access 'default' before initialization".
This happened because V8 sets module status to
Evaluatedimmediately after callingmodule.evaluate(), even when TLA is pending. Deno would seeEvaluatedstatus and try to resolve immediately, exposing uninitialized bindings (TDZ violation).The fix queues subsequent import resolvers in
pending_tla_waiterswhen a module has pending TLA, and resolves them all when the TLA promise completes.