chore: enable windows-sys features in specific members #31679
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to workspace feature unification, enabling a feature of `windows-sys` in any workspace member enabled it for all. However, this doesn't help projects that depend on Deno crates for embedding purposes. For example, [Exograph](https://github.com/exograph/exograph) needed to add an [explicit `windows-sys` dependency](https://github.com/exograph/exograph/blob/e6981bbfba9328abb0f2c6edfcc06b3537f1ee81/libs/exo-deno/Cargo.toml#L49) only to make Deno dependencies compile. This change enables additional `windows-sys` features (beyond those declared in the workspace Cargo.toml) needed by each member. For `deno_subprocess_windows`, process.rs refers to `GetSystemDirectoryW`, which is behind the `Win32_System_SystemInformation` feature. For `deno_node`, dns.rs refers to `WinSock`, which is behind the `Win32_Networking_WinSock` feature.
|
|
bartlomieju
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables additional
windows-sysfeatures (beyond those declared in the workspace Cargo.toml) needed by each member.Due to workspace feature unification, enabling a feature of
windows-sysin any workspace member enabled it for all. However, this doesn't help projects that depend on Deno crates for embedding purposes. For example, Exograph needed to add an explicitwindows-sysdependency only to make Deno dependencies compile.For
deno_subprocess_windows, process.rs refers toGetSystemDirectoryW, which is behind theWin32_System_SystemInformationfeature.For
deno_node, dns.rs refers toWinSock, which is behind theWin32_Networking_WinSockfeature.Fixes #31678