feat(net): Add meanings for missing port/path on listenDatagram
#31681
+99
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ntninja
force-pushed
the
feat-dgram-missing-addr
branch
3 times, most recently
from
076f396 to
4fde6b0
Compare
ntninja
force-pushed
the
feat-dgram-missing-addr
branch
from
4fde6b0 to
d5bf46a
Compare
ntninja
force-pushed
the
feat-dgram-missing-addr
branch
from
d5bf46a to
19f2799
Compare
ntninja
force-pushed
the
feat-dgram-missing-addr
branch
from
19f2799 to
0907105
Compare
ntninja
force-pushed
the
feat-dgram-missing-addr
branch
from
0907105 to
e696434
Compare
Validation is also stricter for client ports, which now has to be in range 1-65535, as connecting to “port 0” is invalid.
…ing an unbound socket Useful if the socket is only used to send messages, but not receive them. (ie: syslog, readiness notify socket, …)
ntninja
force-pushed
the
feat-dgram-missing-addr
branch
from
e696434 to
ecace9d
Compare
Author
|
You should probably configure your CI so that it doesn’t reschedule all tests after they already passed when the PR was set to draft, then changed again to ready… In any case: This is ready and passes now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For UDP this means: No port → port 0 → OS will assign ephermal port
For UDS this means: No path → Use
::unbound()constructor from tokio → socket will be unbound (and therefore unable to receive messages)Fixes #31661
Fixes #14214