fix(ext/web): handle empty TextDecoder input when stream is true #31691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertcanaltin
force-pushed
the
mert/fix/textdecoder-stream-empty-chunk
branch
from
de28040 to
7f39652
Compare
ChALkeR
reviewed
Dec 20, 2025
ChALkeR
reviewed
Dec 20, 2025
mertcanaltin
commented
Dec 20, 2025
…hub.com/mertcanaltin/deno into mert/fix/textdecoder-stream-empty-chunk
bartlomieju
reviewed
Jan 7, 2026
bartlomieju
changed the title
Member
|
@mertcanaltin looks like the tests you added are failing |
… character mappings
Contributor
Author
thanks for review, I edited now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for:
#31605 (comment)
fixes the issue where TextDecoder with stream: true and an empty chunk would return incorrect results.
It resolves the chunking problem for legacy encodings like big5, shift_jis, and euc-kr.