feat(lsp): add test coverage support #31739
Open
+198
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements test coverage visualization for the LSP testing API.
When the test run kind is `coverage`, the LSP passes `--coverage=<temp_dir>`
to `deno test`, collects the V8 coverage JSON files after execution, and
sends a new `deno/testCoverage` notification to the client.
The notification payload includes:
- File URIs with their coverage data
- Arrays of covered and uncovered line numbers (1-indexed)
- Coverage percentage per file
The implementation parses the V8 ScriptCoverage format, converts character
offsets to line numbers, and filters out external dependencies (only files
under the workspace are reported).
Technical details:
- New types in `cli/lsp/testing/lsp_custom.rs`: `FileCoverage`,
`CoverageNotificationParams`
- Coverage collection in `cli/lsp/testing/execution.rs`:
`collect_coverage_from_dir()` reads and parses the JSON files
- The coverage directory is created in the system temp folder as
`deno_lsp_coverage_{run_id}` and cleaned up after sending the notification
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements test coverage visualization for the LSP testing API (closes #18147).
When the test run kind is
coverage, the LSP passes--coverage=<temp_dir>todeno test, collects the V8 coverage JSON files after execution, and sends a newdeno/testCoveragenotification to the client.The notification payload includes:
The implementation parses the V8 ScriptCoverage format, converts character offsets to line numbers, and filters out external dependencies (only files under the workspace are reported).
Technical details:
cli/lsp/testing/lsp_custom.rs:FileCoverage,CoverageNotificationParamscli/lsp/testing/execution.rs:collect_coverage_from_dir()reads and parses the JSON filesdeno_lsp_coverage_{run_id}and cleaned up after sending the notificationTesting:
To test locally, use the vscode_deno extension with the corresponding PR and run any test file with "Run with Coverage" from the Testing panel.
1352
Screenshots will be added in a follow-up comment.
