fix(runtime): suppress newline after EOF in prompt() #31750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When stdin is closed (EOF),
prompt()was outputting an extra newline compared toconfirm()andalert(). This inconsistency was caused by rustyline's internal terminal handling.Root Cause
prompt()usesop_read_line_prompt()which internally uses rustyline'sEditor::readline_with_initialconfirm()andalert()usereadLineFromStdinSync()which is a manual byte-by-byte readFix
This PR adds an ANSI escape sequence (
\x1b[1A) to move the cursor up after EOF is received, counteracting the unwanted newline that rustyline outputs.Testing
Fixes #22956