Skip to content

feat(npm): support jsr: scheme in package.json #31938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsherret wants to merge 4 commits into
base: main
Choose a base branch
from
+274 −279
Open

feat(npm): support jsr: scheme in package.json #31938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3d00aa
feat(npm): support `jsr:` scheme in package.json
dsherret Jan 23, 2026
5a65064
fix test
dsherret Jan 23, 2026
f800ec4
publish @jsr scoped deps to jsr as jsr: specifiers
dsherret Jan 23, 2026
5b0e02d
lint
dsherret Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 0 additions & 7 deletions cli/args/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,13 +447,6 @@ impl WorkspaceMainModuleResolver {
)?
.into_url()?
}
deno_package_json::PackageJsonDepValue::JsrReq(_) => {
return Err(
deno_resolver::DenoResolveErrorKind::UnsupportedPackageJsonJsrReq
.into_box()
.into(),
);
}
}
}
deno_resolver::workspace::MappedResolution::PackageJsonImport {
Expand Down
3 changes: 0 additions & 3 deletions cli/rt/run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,9 +243,6 @@ impl ModuleLoader for EmbeddedModuleLoader {
PackageJsonDepValue::File(_) => Err(JsErrorBox::from_err(
DenoResolveErrorKind::UnsupportedPackageJsonFileSpecifier.into_box(),
)),
PackageJsonDepValue::JsrReq(_) => Err(JsErrorBox::from_err(
DenoResolveErrorKind::UnsupportedPackageJsonJsrReq.into_box(),
)),
PackageJsonDepValue::Req(req) => Ok(
self
.shared
Expand Down
7 changes: 0 additions & 7 deletions cli/tools/info.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,6 @@ pub async fn info(
.into(),
);
}
deno_package_json::PackageJsonDepValue::JsrReq(_) => {
return Err(
DenoResolveErrorKind::UnsupportedPackageJsonJsrReq
.into_box()
.into(),
);
}
deno_package_json::PackageJsonDepValue::Workspace(version_req) => {
let pkg_folder = resolver
.resolve_workspace_pkg_json_folder_for_pkg_json_dep(
Expand Down
6 changes: 0 additions & 6 deletions cli/tools/installer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,9 +517,6 @@ fn categorize_installed_npm_deps(
) => {
// ignore workspace deps
}
deno_package_json::PackageJsonDepValue::JsrReq(_package_req) => {
// ignore jsr deps
}
}
}

Expand All @@ -540,9 +537,6 @@ fn categorize_installed_npm_deps(
) => {
// ignore workspace deps
}
deno_package_json::PackageJsonDepValue::JsrReq(_package_req) => {
// ignore jsr deps
}
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions cli/tools/pm/deps.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,7 @@ fn add_deps_from_package_json(
}
};
match v {
deno_package_json::PackageJsonDepValue::File(_)
| deno_package_json::PackageJsonDepValue::JsrReq(_) => {
deno_package_json::PackageJsonDepValue::File(_) => {
// ignore
}
deno_package_json::PackageJsonDepValue::Req(req) => {
Expand Down
Loading
Loading