fix: apply --watch-exclude filter to file change events
#31976
+146
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AprilNEA
force-pushed
the
fix/watch-exclude-filter
branch
from
39e0613 to
84d9495
Compare
Previously, `--watch-exclude` only filtered paths when registering them with the OS file watcher. When a directory was watched recursively (e.g. `--watch=.`), the OS reported changes to all files within it, including excluded ones, because the exclude check was never applied to incoming change notifications. This fix passes the exclude set into the `new_watcher()` callback and filters changed paths before they enter the debounce channel, ensuring excluded files never trigger a restart. Closes denoland#26217
AprilNEA
force-pushed
the
fix/watch-exclude-filter
branch
from
84d9495 to
97fcc11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
--watch-excludeonly filtered paths when registering them with the OS file watcher. When a directory was watched recursively (e.g.--watch=.), the OS reported changes to all files within it, including excluded ones, because the exclude check was never applied to incoming change notifications.This fix passes the exclude set into the
new_watcher()callback and filters changed paths before they enter the debounce channel, ensuring excluded files never trigger a restart.Closes #26217