fix(node/http): set res.complete before emitting end event #31986
+43
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the timing of when
res.completeis set totrueonIncomingMessageto match Node.js behavior.Fixes #26733
Problem
When using
node:httpfor HTTP requests, theres.completeproperty wasfalseinside theendevent handler, even though the request completed successfully. This broke packages like@adyen/api-librarywhich check:Root Cause
completewas only being set totruein_destroy, which happens AFTER theendeventcompleteis set inparserOnMessageCompleteBEFOREpush(null)triggersendcomplete = truewas set before the!this.completecheckSolution
this.complete = truein_read()BEFORE callingthis.push(null)_destroy()to check!this.completebefore setting it totrueTest plan
completeistrueinendevent🤖 Generated with Claude Code