refactor: use ToV8 on enums instead of serde#31991
Draft
crowlKats wants to merge 1 commit intodenoland:mainfrom
Draft
refactor: use ToV8 on enums instead of serde#31991crowlKats wants to merge 1 commit intodenoland:mainfrom
ToV8 on enums instead of serde#31991crowlKats wants to merge 1 commit intodenoland:mainfrom
Conversation
Contributor
|
What's the benefit of doing this? Genuine question. |
Contributor
|
It seems to be a continuous progression from the changes in denoland/deno_core#1262. Much like Rust structs, it looks like enums have also become easier to convert to and from V8 values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For denoland/deno_core#1292