fix(core): store Global<Context> ptr for libuv-compat callbacks#32361
Merged
bartlomieju merged 1 commit intodenoland:mainfrom Feb 28, 2026
Merged
fix(core): store Global<Context> ptr for libuv-compat callbacks#32361bartlomieju merged 1 commit intodenoland:mainfrom
bartlomieju merged 1 commit intodenoland:mainfrom
Conversation
Instead of storing a `v8::Local<Context>` pointer in `loop_.data` at the start of each event loop tick (which is only valid for that tick), store a `v8::Global<Context>` via `Global::into_raw()` once during `register_uv_loop`. V8 keeps the persistent-handle slot updated across GC cycles, so the pointer remains valid for the lifetime of the runtime. The raw Global is reconstructed and dropped in `JsRealmInner::destroy`. Ported from denoland/deno_core#1315 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
littledivy
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v8::Global<Context>viaGlobal::into_raw()once duringregister_uv_loopinstead of storing av8::Local<Context>pointer at the start of each event loop tickJsRealmInner::destroytransmute+constsize assert that was previously neededPorted from denoland/deno_core#1315
Original author: @littledivy
Test plan
cargo check -p deno_corepasses🤖 Generated with Claude Code