Skip to content

perf(install): use aws-lc-rs for tarball integrity hashing#32365

Merged
nathanwhit merged 1 commit intodenoland:mainfrom
nathanwhit:aws-lc-hashing
Feb 28, 2026
Merged

perf(install): use aws-lc-rs for tarball integrity hashing#32365
nathanwhit merged 1 commit intodenoland:mainfrom
nathanwhit:aws-lc-hashing

Conversation

@nathanwhit
Copy link
Member

It's just generally faster at hashing. Small perf improvement but we already use aws-lc-rs elsewhere anyway

Benchmark 1: ~/Documents/Code/deno/target/release-lite/deno install
  Time (mean ± σ):      2.373 s ±  0.204 s    [User: 0.927 s, System: 1.002 s]
  Range (min … max):    2.144 s …  2.701 s    10 runs

Benchmark 2: ~/Documents/Code/deno/target/deno-baseline install
  Time (mean ± σ):      2.429 s ±  0.233 s    [User: 0.947 s, System: 1.067 s]
  Range (min … max):    2.218 s …  2.870 s    10 runs

Summary
  ~/Documents/Code/deno/target/release-lite/deno install ran
    1.02 ± 0.13 times faster than ~/Documents/Code/deno/target/deno-baseline inst

Replace sha1 and sha2 crate usage with aws-lc-rs which provides
hardware-accelerated SHA implementations. This speeds up tarball
integrity verification.
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nathanwhit nathanwhit merged commit 6adddf9 into denoland:main Feb 28, 2026
327 of 332 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants