fix: respond to interrupt and shutdown request#32367
Closed
rgbkrk wants to merge 1 commit intodenoland:mainfrom
Closed
fix: respond to interrupt and shutdown request#32367rgbkrk wants to merge 1 commit intodenoland:mainfrom
rgbkrk wants to merge 1 commit intodenoland:mainfrom
Conversation
Even though we can't yet handle interrupts (can we even with V8's interpreter?), we should at least create an interrupt reply that states an error. Discovered during Jupyter conformance tests across kernels: https://runtimed.github.io/kernel-testbed/kernel/deno/
rgbkrk
force-pushed
the
quill/jupyter-control-channel
branch
from
92354b9 to
7dbe690
Compare
Contributor
Author
|
Closing in favor of #32359 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though we can't yet handle interrupts (can we even with V8's interpreter?), we should at least create an interrupt reply that states an error. This was discovered during Jupyter conformance tests across kernels: https://runtimed.github.io/kernel-testbed/kernel/deno/